Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 2049503004: Add a "not signed in" condition to the Sync promo in the password bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_bubble_experiment.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
index 94430d5d71c61aeec4bc2c8066d3ea02bf006565..8fe645bced0a05f365b9f48794204d786f0bba78 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
@@ -460,7 +460,10 @@ bool ManagePasswordsBubbleModel::ShouldShowGoogleSmartLockWelcome() const {
bool ManagePasswordsBubbleModel::ReplaceToShowSignInPromoIfNeeded() {
DCHECK_EQ(password_manager::ui::PENDING_PASSWORD_STATE, state_);
PrefService* prefs = GetProfile()->GetPrefs();
- if (password_bubble_experiment::ShouldShowChromeSignInPasswordPromo(prefs)) {
+ const ProfileSyncService* sync_service =
+ ProfileSyncServiceFactory::GetForProfile(GetProfile());
+ if (password_bubble_experiment::ShouldShowChromeSignInPasswordPromo(
+ prefs, sync_service)) {
interaction_keeper_->ReportInteractions(this);
title_brand_link_range_ = gfx::Range();
title_ = l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_SIGNIN_PROMO_TITLE);
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_bubble_experiment.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698