components/password_manager/core/browser/password_bubble_experiment.h - Issue 2049503004: Add a "not signed in" condition to the Sync promo in the password bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_bubble_experiment.h

Issue 2049503004: Add a "not signed in" condition to the Sync promo in the password bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('k') | components/password_manager/core/browser/password_bubble_experiment.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_bubble_experiment.h

diff --git a/components/password_manager/core/browser/password_bubble_experiment.h b/components/password_manager/core/browser/password_bubble_experiment.h

index 7e68da419f1559a3a9c7f7be1ff6f7ebe2cfef7a..f2ce04eed34104b54942619eddeb5ecf8f5596d2 100644

--- a/components/password_manager/core/browser/password_bubble_experiment.h

+++ b/components/password_manager/core/browser/password_bubble_experiment.h

@@ -74,7 +74,9 @@ void RecordAutoSignInPromptFirstRunExperienceWasShown(PrefService* prefs);

void TurnOffAutoSignin(PrefService* prefs);

// Returns true if the Chrome Sign In promo should be shown.

-bool ShouldShowChromeSignInPasswordPromo(PrefService* prefs);

+bool ShouldShowChromeSignInPasswordPromo(

+ PrefService* prefs,

+ const sync_driver::SyncService* sync_service);

} // namespace password_bubble_experiment