binding: Uses the relevant realm instead of the current realm (1 of ?)

binding: Uses the relevant realm instead of the current realm (1 of ?)

There are many places where we're passing the current realm instead of
the relevant realm of the platform object, and it's wrong.  This CL
fixes most of those but not all.  Following CLs may fix the rest.

BUG=618672, 560308
Committed: https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b
Cr-Commit-Position: refs/heads/master@{#407133}

[Yuki, 2016-06-10 06:00:14]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2016-06-10 06:00:15]

Could you review this CL?

[haraken, 2016-06-10 06:22:37]

This change looks good, but I might want to have an overall plan (i.e. design
doc) before making these changes. Specifically, I want to clarify:

- How ScriptState should be used in Blink.
- What context should be passed in to V8 APIs (or whether we should remove the
context parameter from V8 APIs).
- How each context should be retrieved in bindings (e.g., should we implement
info.GetRelevantContext()?).

Once we have a plan and reach consensus, we can make the changes more
consistently and confidently. I'm a bit concerned about making the changes
randomly because it can change web-exposed behaviors (although the changes will
be very subtle).

[Yuki, 2016-07-22 08:26:06]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 08:26:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-07-22 09:47:15]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 09:47:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-07-22 09:48:56]

haraken@, could you take another look at this CL?

I think we agree on this way, and it's now okay to go with this CL.  Updated a
layout test for window.setTimeout to confirm the change.

[haraken, 2016-07-22 09:51:02]

LGTM, go for it!

https://codereview.chromium.org/2049493005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ScriptState.h (right):

https://codereview.chromium.org/2049493005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ScriptState.h:60: static ScriptState*
forThisObject(const v8::FunctionCallbackInfo<v8::Value>& info)

Nit: 'This' object sounds a bit too vague. I'd prefer 'Holder' object or
'Receiver' object.

[Yuki, 2016-07-22 10:11:03]

https://codereview.chromium.org/2049493005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ScriptState.h (right):

https://codereview.chromium.org/2049493005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ScriptState.h:60: static ScriptState*
forThisObject(const v8::FunctionCallbackInfo<v8::Value>& info)
On 2016/07/22 09:51:01, haraken wrote:
> 
> Nit: 'This' object sounds a bit too vague. I'd prefer 'Holder' object or
> 'Receiver' object.

Good point.  Agreed.  Let's name this "forHolderObject".

[Yuki, 2016-07-22 10:11:07]

The CQ bit was checked by yukishiino@chromium.org

[Yuki, 2016-07-22 10:11:08]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2049493005/#ps100001
(title: "Addressed a review comment.")

[commit-bot: I haz the power, 2016-07-22 10:11:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 11:49:41]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-22 11:51:03]

Description was changed from

==========
binding: Uses the relevant realm instead of the current realm (1 of ?)

There are many places where we're passing the current realm instead of
the relevant realm of the platform object, and it's wrong.  This CL
fixes most of those but not all.  Following CLs may fix the rest.

BUG=618672,560308
==========

to

==========
binding: Uses the relevant realm instead of the current realm (1 of ?)

There are many places where we're passing the current realm instead of
the relevant realm of the platform object, and it's wrong.  This CL
fixes most of those but not all.  Following CLs may fix the rest.

BUG=618672,560308

Committed: https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b
Cr-Commit-Position: refs/heads/master@{#407133}
==========

[commit-bot: I haz the power, 2016-07-22 11:51:04]

Patchset 6 (id:??) landed as
https://crrev.com/36f52aca24a7fdf60ff33ada980e663e550b622b
Cr-Commit-Position: refs/heads/master@{#407133}