third_party/WebKit/LayoutTests/fast/dom/Window/timeout-callback-scope-expected.txt - Issue 2049493005: binding: Uses the relevant realm instead of the current realm (1 of ?)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Window/timeout-callback-scope-expected.txt

Issue 2049493005: binding: Uses the relevant realm instead of the current realm (1 of ?) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed a review comment. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/Window/timeout-callback-scope.html ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/Window/timeout-callback-scope-expected.txt

diff --git a/third_party/WebKit/LayoutTests/fast/dom/Window/timeout-callback-scope-expected.txt b/third_party/WebKit/LayoutTests/fast/dom/Window/timeout-callback-scope-expected.txt

index 484ad6cc8b85bb7121b666230cda3b00898e56b7..7d036912226f6013d38aa433a973c64253669bea 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/Window/timeout-callback-scope-expected.txt

+++ b/third_party/WebKit/LayoutTests/fast/dom/Window/timeout-callback-scope-expected.txt

@@ -1,4 +1,5 @@

-Test verifies that a timeout callback is run in the proper execution context. 2 timeouts are set on a child iframe's window. 'Closure' callback should execute in the main page, 'string' callback should execute in the iframe. Test passes if you see 2 lines 'PASS' below.

+Test verifies that a timeout callback is run in the proper execution context. 3 timeouts are set on a child iframe's window. Test passes if you see 3 lines 'PASS' below. See also: https://html.spec.whatwg.org/multipage/webappapis.html#timer-initialisation-steps

-PASS

+PASS -- function argument: if the argument is a function, then the callback function must run in the relevant realm for that function object.

+PASS -- string argument: if the argument is a string, then it must be compiled in the relevant realm for the context object, hence must run in the relevant realm for the context object.

+PASS -- callback this value: the callback this value must be the context object.