src/trusted/service_runtime/BUILD.gn - Issue 2049033004: Fix NaCl executable linkages under ASAN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/BUILD.gn

Issue 2049033004: Fix NaCl executable linkages under ASAN. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: add deps to sel_ldr, ncval_new as well Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/trusted/service_runtime/BUILD.gn

diff --git a/src/trusted/service_runtime/BUILD.gn b/src/trusted/service_runtime/BUILD.gn

index fdd71b9d0ec529d5d4cddcc22caba2985d8cc50e..7be0b966d7070340cb8433c477bc9eaf1cd1bb60 100644

--- a/src/trusted/service_runtime/BUILD.gn

+++ b/src/trusted/service_runtime/BUILD.gn

@@ -336,6 +336,11 @@ executable("sel_ldr") {

]

deps = [

":sel_main",

+ # All executables must have the sanitizer deps to properly link in

+ # asan mode (this target will be empty in other cases).

+ "//build/config/sanitizers:deps",

"//build/win:default_exe_manifest",

]

if (is_linux) {

« no previous file with comments | « src/trusted/debug_stub/BUILD.gn ('k') | src/trusted/validator/driver/BUILD.gn » ('j') | src/trusted/validator/driver/BUILD.gn » ('J')