Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: src/trusted/debug_stub/BUILD.gn

Issue 2049033004: Fix NaCl executable linkages under ASAN. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: add deps to sel_ldr, ncval_new as well Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/trusted/service_runtime/BUILD.gn » ('j') | src/trusted/validator/driver/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/debug_stub/BUILD.gn
diff --git a/src/trusted/debug_stub/BUILD.gn b/src/trusted/debug_stub/BUILD.gn
index 2594c1f235c2b035bedbf56604cc5e5f02da5231..c24839ce015bca6261c865f0424ed99f5700a322 100644
--- a/src/trusted/debug_stub/BUILD.gn
+++ b/src/trusted/debug_stub/BUILD.gn
@@ -1,6 +1,7 @@
# Copyright (c) 2014 The Native ClientAuthors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/sanitizers/sanitizers.gni")
static_library("debug_stub") {
sources = [
@@ -45,8 +46,12 @@ executable("gdb_rsp_unittest") {
]
deps = [
+ ":debug_stub",
"//build/config/nacl:nacl_base",
+
+ # All executables must have the sanitizer deps to properly link in
+ # asan mode (this target will be empty in other cases).
+ "//build/config/sanitizers:deps",
"//build/win:default_exe_manifest",
- ":debug_stub",
]
}
« no previous file with comments | « no previous file | src/trusted/service_runtime/BUILD.gn » ('j') | src/trusted/validator/driver/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698