Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: src/trusted/validator/driver/BUILD.gn

Issue 2049033004: Fix NaCl executable linkages under ASAN. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: add deps to sel_ldr, ncval_new as well Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/service_runtime/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator/driver/BUILD.gn
diff --git a/src/trusted/validator/driver/BUILD.gn b/src/trusted/validator/driver/BUILD.gn
index 7f73ad81f6f0cf17922a28305686b1d5a8375753..0af4ce3a9167255a32ea7860aae8555b8501eb2a 100644
--- a/src/trusted/validator/driver/BUILD.gn
+++ b/src/trusted/validator/driver/BUILD.gn
@@ -21,6 +21,11 @@ executable("ncval_new") {
deps = [
"//build/config/nacl:nacl_base",
+
+ # All executables must have the sanitizer deps to properly link in
+ # asan mode (this target will be empty in other cases).
+ "//build/config/sanitizers:deps",
+
"//build/win:default_exe_manifest",
":elf_load",
"//native_client/src/shared/platform:platform",
« no previous file with comments | « src/trusted/service_runtime/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698