Fix chrome_telemetry_build's GN dependencies for Mac OS X.

Fix chrome_telemetry_build's GN dependencies for Mac OS X.

(taking over from caseq's https://codereview.chromium.org/2037773005/ )

The previous bug workaround for Issue 536192 should no longer be
necessary.

Expand OWNERS for chrome/BUILD.gn to include GN OWNERS.
Relax .gni ownership.

BUG=599776
Committed: https://crrev.com/11d078ce662fd79da785df0565b3c30482e05a51
Cr-Commit-Position: refs/heads/master@{#398466}

[Ken Russell (switch to Gerrit), 2016-06-07 04:37:15]

kbr@chromium.org changed reviewers:
+ aiolos@chromium.org, caseq@chromium.org, dpranke@chromium.org

[Ken Russell (switch to Gerrit), 2016-06-07 04:37:15]

Dirk: please re-review if the bots are green. Addressed your review feedback
from https://codereview.chromium.org/2037773005/ .

[Dirk Pranke, 2016-06-07 22:23:02]

The bots are definitely not green ;)

lgtm if they are with the fix noted below, though.

https://codereview.chromium.org/2048563002/diff/1/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2048563002/diff/1/chrome/BUILD.gn#newcode71
chrome/BUILD.gn:71: data_deps = [
This needs to be += now.

[Ken Russell (switch to Gerrit), 2016-06-07 23:45:13]

kbr@chromium.org changed reviewers:
+ nednguyen@google.com
- aiolos@chromium.org

[Ken Russell (switch to Gerrit), 2016-06-07 23:45:14]

nednguyen: OWNERS review please -- however, this is still broken, so I'll need
to keep digging.

[nednguyen, 2016-06-07 23:49:53]

lgtm

[Ken Russell (switch to Gerrit), 2016-06-07 23:54:08]

https://codereview.chromium.org/2048563002/diff/1/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2048563002/diff/1/chrome/BUILD.gn#newcode71
chrome/BUILD.gn:71: data_deps = [
On 2016/06/07 22:23:02, Dirk Pranke wrote:
> This needs to be += now.

Done.

[Ken Russell (switch to Gerrit), 2016-06-07 23:57:29]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-06-07 23:57:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2048563002/#ps20001
(title: "Fix data_deps inside group("chrome").")

[commit-bot: I haz the power, 2016-06-07 23:58:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048563002/20001

[Ken Russell (switch to Gerrit), 2016-06-07 23:59:47]

The telemetry_unittests failures are http://crbug.com/616483 .

[commit-bot: I haz the power, 2016-06-08 00:07:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 00:07:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Russell (switch to Gerrit), 2016-06-08 00:21:19]

Description was changed from

==========
Fix chrome_telemetry_build's GN dependencies for Mac OS X.

(taking over from caseq's https://codereview.chromium.org/2037773005/ )

The previous bug workaround for Issue 536192 should no longer be
necessary.

BUG=599776
==========

to

==========
Fix chrome_telemetry_build's GN dependencies for Mac OS X.

(taking over from caseq's https://codereview.chromium.org/2037773005/ )

The previous bug workaround for Issue 536192 should no longer be
necessary.

Expand OWNERS for chrome/BUILD.gn to include GN OWNERS.
Relax .gni ownership.

BUG=599776
==========

[Ken Russell (switch to Gerrit), 2016-06-08 00:21:19]

kbr@chromium.org changed reviewers:
+ thestig@chromium.org

[Ken Russell (switch to Gerrit), 2016-06-08 00:21:48]

It's ridiculous that dpranke's not an OWNER of chrome/BUILD.gn. Fixed this.
thestig@: please review. Thanks.

[Lei Zhang, 2016-06-08 00:25:46]

lgtm

[Ken Russell (switch to Gerrit), 2016-06-08 00:28:47]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-06-08 00:28:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2048563002/#ps40001
(title: "Add GN reviewers as per-file OWNERS. Relax .gni ownership.")

[commit-bot: I haz the power, 2016-06-08 00:29:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048563002/40001

[commit-bot: I haz the power, 2016-06-08 02:36:02]

Description was changed from

==========
Fix chrome_telemetry_build's GN dependencies for Mac OS X.

(taking over from caseq's https://codereview.chromium.org/2037773005/ )

The previous bug workaround for Issue 536192 should no longer be
necessary.

Expand OWNERS for chrome/BUILD.gn to include GN OWNERS.
Relax .gni ownership.

BUG=599776
==========

to

==========
Fix chrome_telemetry_build's GN dependencies for Mac OS X.

(taking over from caseq's https://codereview.chromium.org/2037773005/ )

The previous bug workaround for Issue 536192 should no longer be
necessary.

Expand OWNERS for chrome/BUILD.gn to include GN OWNERS.
Relax .gni ownership.

BUG=599776
==========

[commit-bot: I haz the power, 2016-06-08 02:36:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-08 02:37:37]

Description was changed from

==========
Fix chrome_telemetry_build's GN dependencies for Mac OS X.

(taking over from caseq's https://codereview.chromium.org/2037773005/ )

The previous bug workaround for Issue 536192 should no longer be
necessary.

Expand OWNERS for chrome/BUILD.gn to include GN OWNERS.
Relax .gni ownership.

BUG=599776
==========

to

==========
Fix chrome_telemetry_build's GN dependencies for Mac OS X.

(taking over from caseq's https://codereview.chromium.org/2037773005/ )

The previous bug workaround for Issue 536192 should no longer be
necessary.

Expand OWNERS for chrome/BUILD.gn to include GN OWNERS.
Relax .gni ownership.

BUG=599776

Committed: https://crrev.com/11d078ce662fd79da785df0565b3c30482e05a51
Cr-Commit-Position: refs/heads/master@{#398466}
==========

[commit-bot: I haz the power, 2016-06-08 02:37:38]

Patchset 3 (id:??) landed as
https://crrev.com/11d078ce662fd79da785df0565b3c30482e05a51
Cr-Commit-Position: refs/heads/master@{#398466}