Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: chrome/BUILD.gn

Issue 2048563002: Fix chrome_telemetry_build's GN dependencies for Mac OS X. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add GN reviewers as per-file OWNERS. Relax .gni ownership. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index a26eac994c5d5970ab14ec5c3cf25719c068ce3f..1f15d72e070a1a67d3658558713d7343c537483c 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -61,13 +61,14 @@ if (!is_android && !is_mac) {
public_deps = [
":chrome_initial",
]
+ data_deps = [
+ ":chrome_initial",
+ ]
if (is_win) {
public_deps += [ ":reorder_imports" ]
}
if (use_aura && (is_win || is_linux)) {
- data_deps = [
- "//chrome/app:mojo_manifests",
- ]
+ data_deps += [ "//chrome/app:mojo_manifests" ]
}
}
@@ -427,6 +428,10 @@ if (is_win) {
":chrome_app",
]
+ data_deps = [
+ ":chrome_app",
+ ]
+
if (debug_devtools) {
deps += [ ":devtools_debug_resources" ]
}
« no previous file with comments | « no previous file | chrome/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698