Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Side by Side Diff: chrome/BUILD.gn

Issue 2048563002: Fix chrome_telemetry_build's GN dependencies for Mac OS X. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add GN reviewers as per-file OWNERS. Relax .gni ownership. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/OWNERS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 ":chrome_initial", 54 ":chrome_initial",
55 ] 55 ]
56 } 56 }
57 } 57 }
58 58
59 if (!is_android && !is_mac) { 59 if (!is_android && !is_mac) {
60 group("chrome") { 60 group("chrome") {
61 public_deps = [ 61 public_deps = [
62 ":chrome_initial", 62 ":chrome_initial",
63 ] 63 ]
64 data_deps = [
65 ":chrome_initial",
66 ]
64 if (is_win) { 67 if (is_win) {
65 public_deps += [ ":reorder_imports" ] 68 public_deps += [ ":reorder_imports" ]
66 } 69 }
67 if (use_aura && (is_win || is_linux)) { 70 if (use_aura && (is_win || is_linux)) {
68 data_deps = [ 71 data_deps += [ "//chrome/app:mojo_manifests" ]
69 "//chrome/app:mojo_manifests",
70 ]
71 } 72 }
72 } 73 }
73 74
74 executable("chrome_initial") { 75 executable("chrome_initial") {
75 if (is_win) { 76 if (is_win) {
76 output_name = "initialexe/chrome" 77 output_name = "initialexe/chrome"
77 } else { 78 } else {
78 output_name = "chrome" 79 output_name = "chrome"
79 } 80 }
80 81
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
420 } 421 }
421 } else if (is_mac) { 422 } else if (is_mac) {
422 chrome_helper_name = chrome_product_full_name + " Helper" 423 chrome_helper_name = chrome_product_full_name + " Helper"
423 chrome_framework_name = chrome_product_full_name + " Framework" 424 chrome_framework_name = chrome_product_full_name + " Framework"
424 425
425 group("chrome") { 426 group("chrome") {
426 deps = [ 427 deps = [
427 ":chrome_app", 428 ":chrome_app",
428 ] 429 ]
429 430
431 data_deps = [
432 ":chrome_app",
433 ]
434
430 if (debug_devtools) { 435 if (debug_devtools) {
431 deps += [ ":devtools_debug_resources" ] 436 deps += [ ":devtools_debug_resources" ]
432 } 437 }
433 } 438 }
434 439
435 tweak_info_plist("chrome_app_plist") { 440 tweak_info_plist("chrome_app_plist") {
436 info_plist = "app/app-Info.plist" 441 info_plist = "app/app-Info.plist"
437 _keystone_arg = "0" 442 _keystone_arg = "0"
438 if (enable_mac_keystone) { 443 if (enable_mac_keystone) {
439 _keystone_arg = "1" 444 _keystone_arg = "1"
(...skipping 1223 matching lines...) Expand 10 before | Expand all | Expand 10 after
1663 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1668 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1664 "//chrome/tools/build/linux/chrome-wrapper", 1669 "//chrome/tools/build/linux/chrome-wrapper",
1665 "//third_party/xdg-utils/scripts/xdg-mime", 1670 "//third_party/xdg-utils/scripts/xdg-mime",
1666 "//third_party/xdg-utils/scripts/xdg-settings", 1671 "//third_party/xdg-utils/scripts/xdg-settings",
1667 ] 1672 ]
1668 outputs = [ 1673 outputs = [
1669 "$root_out_dir/{{source_file_part}}", 1674 "$root_out_dir/{{source_file_part}}",
1670 ] 1675 ]
1671 } 1676 }
1672 } 1677 }
OLDNEW
« no previous file with comments | « no previous file | chrome/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698