Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2048483002: Plumb TransformValue into the 'transform' property of StylePropertyMap. (Closed)

Created:
4 years, 6 months ago by meade_UTC10
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@stylevaue
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb TransformValue into the 'transform' property of StylePropertyMap. This allows TransformValues to be inserted into the InlineStylePropertyMap. It does not yet allow them to be retrieved from any of the StylePropertyMaps. I'm working on that in https://codereview.chromium.org/2039093003. BUG=545318 Committed: https://crrev.com/723ac13bb8869423ce1f720f6f76efa35de1ea2d Cr-Commit-Position: refs/heads/master@{#398264}

Patch Set 1 #

Patch Set 2 : Add Layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform.html View 1 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/TransformValue.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
meade_UTC10
4 years, 6 months ago (2016-06-07 01:33:13 UTC) #2
Timothy Loh
On 2016/06/07 01:33:13, Eddy wrote: lgtm
4 years, 6 months ago (2016-06-07 04:00:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048483002/20001
4 years, 6 months ago (2016-06-07 08:18:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 10:08:52 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 10:10:09 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/723ac13bb8869423ce1f720f6f76efa35de1ea2d
Cr-Commit-Position: refs/heads/master@{#398264}

Powered by Google App Engine
This is Rietveld 408576698