Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 2036893003: [CSS Typed OM] Rename StyleValue -> CSSStyleValue (Closed)

Created:
4 years, 6 months ago by meade_UTC10
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh, bashi
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, blink-reviews-bindings_chromium.org, rjwright, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Typed OM] Rename StyleValue -> CSSStyleValue This matches the most recent update of the spec: https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects BUG=545318 Committed: https://crrev.com/e8da8332f009d057d803c9dee59bbdc7b3c59078 Cr-Commit-Position: refs/heads/master@{#398248}

Patch Set 1 #

Patch Set 2 : Update order of core.gypi #

Total comments: 4

Patch Set 3 : Make list of generated files alphabetical #

Patch Set 4 : Update LayoutTests too #

Patch Set 5 : update global-interface-listing-expected as well #

Patch Set 6 : Sync to head #

Patch Set 7 : Update names in new code too #

Patch Set 8 : Update more union types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -234 lines) Patch
M third_party/WebKit/LayoutTests/typedcssom/styleValue-parse-basic.html View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/transformValue.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 7 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/generated.gni View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/generated.gypi View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSAngleValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSAngleValue.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSLengthValue.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSNumberValue.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSNumberValue.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSOMTypes.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPositionValue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSPositionValue.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSStyleValue.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/ImmutableStylePropertyMap.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp View 1 2 3 4 5 6 7 5 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h View 1 2 3 4 5 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp View 1 2 3 4 5 6 7 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMap.idl View 1 chunk +5 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/StyleValue.h View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/StyleValue.cpp View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/StyleValue.idl View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleValueFactory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/TransformValue.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/TransformValue.idl View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 34 (18 generated)
meade_UTC10
4 years, 6 months ago (2016-06-03 07:43:49 UTC) #2
Timothy Loh
On 2016/06/03 07:43:49, Eddy wrote: lgtm
4 years, 6 months ago (2016-06-03 08:46:22 UTC) #3
meade_UTC10
bashi@chromium.org: Please review changes in third_party/WebKit/Source/bindings/core/v8/generated.gni and generated.gypi Thank you! Eddy
4 years, 6 months ago (2016-06-06 06:35:03 UTC) #5
bashi
bindings/ lgtm with nits https://codereview.chromium.org/2036893003/diff/20001/third_party/WebKit/Source/bindings/core/v8/generated.gni File third_party/WebKit/Source/bindings/core/v8/generated.gni (right): https://codereview.chromium.org/2036893003/diff/20001/third_party/WebKit/Source/bindings/core/v8/generated.gni#newcode85 third_party/WebKit/Source/bindings/core/v8/generated.gni:85: "$bindings_core_v8_output_dir/CSSStyleValueOrCSSStyleValueSequence.cpp", nit: alphabetical order https://codereview.chromium.org/2036893003/diff/20001/third_party/WebKit/Source/bindings/core/v8/generated.gypi ...
4 years, 6 months ago (2016-06-06 06:41:53 UTC) #6
meade_UTC10
Thank you very much! https://codereview.chromium.org/2036893003/diff/20001/third_party/WebKit/Source/bindings/core/v8/generated.gni File third_party/WebKit/Source/bindings/core/v8/generated.gni (right): https://codereview.chromium.org/2036893003/diff/20001/third_party/WebKit/Source/bindings/core/v8/generated.gni#newcode85 third_party/WebKit/Source/bindings/core/v8/generated.gni:85: "$bindings_core_v8_output_dir/CSSStyleValueOrCSSStyleValueSequence.cpp", On 2016/06/06 06:41:53, bashi1 ...
4 years, 6 months ago (2016-06-06 06:45:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036893003/40001
4 years, 6 months ago (2016-06-06 06:46:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036893003/80001
4 years, 6 months ago (2016-06-07 01:23:19 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/82960)
4 years, 6 months ago (2016-06-07 02:00:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036893003/80001
4 years, 6 months ago (2016-06-07 03:31:34 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/82998)
4 years, 6 months ago (2016-06-07 03:37:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036893003/100001
4 years, 6 months ago (2016-06-07 04:08:43 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/77455) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-07 04:19:37 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036893003/120001
4 years, 6 months ago (2016-06-07 04:23:40 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036893003/140001
4 years, 6 months ago (2016-06-07 04:29:03 UTC) #31
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 6 months ago (2016-06-07 08:10:57 UTC) #32
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 08:13:20 UTC) #34
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/e8da8332f009d057d803c9dee59bbdc7b3c59078
Cr-Commit-Position: refs/heads/master@{#398248}

Powered by Google App Engine
This is Rietveld 408576698