Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2039093003: [Typed OM] Implement CSSValue->CSSRotation conversion (Closed)

Created:
4 years, 6 months ago by meade_UTC10
Modified:
4 years, 5 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Typed OM] Implement CSSValue->CSSRotation conversion The other TransformComponents (CSSMatrixTransformComponent, CSSPerspective, CSSScale, CSSSkew, CSSTranslation) just return nullptr for now. BUG=545318 Committed: https://crrev.com/8e8a560b7fe01f67f3a408e406948a4e3d5f37a1 Cr-Commit-Position: refs/heads/master@{#402267}

Patch Set 1 #

Patch Set 2 : Start work on reverse path #

Patch Set 3 : Reparent branch #

Patch Set 4 : Sync to head and update types in new code #

Patch Set 5 : Reparent branch, sync #

Patch Set 6 : Move everything other than rotation out of the patch #

Patch Set 7 : #

Patch Set 8 : Sync to HEAD #

Patch Set 9 : Merge branch 'supported-types0' into supported-types #

Patch Set 10 : Sync to HEAD #

Total comments: 4

Patch Set 11 : Add support for rotateX, rotateY, rotateZ #

Patch Set 12 : Make sure units are right for non-degree rotateXYZ #

Patch Set 13 : fix integer types #

Total comments: 8

Patch Set 14 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform.html View 1 2 5 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-rotation.html View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +119 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSRotation.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
meade_UTC10
4 years, 6 months ago (2016-06-14 14:47:00 UTC) #6
Timothy Loh
https://codereview.chromium.org/2039093003/diff/180001/third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp File third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp (right): https://codereview.chromium.org/2039093003/diff/180001/third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp#newcode32 third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp:32: if (value.functionType() == CSSValueRotate) { This also needs to ...
4 years, 6 months ago (2016-06-15 08:36:26 UTC) #7
meade_UTC10
https://codereview.chromium.org/2039093003/diff/180001/third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp File third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp (right): https://codereview.chromium.org/2039093003/diff/180001/third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp#newcode32 third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp:32: if (value.functionType() == CSSValueRotate) { On 2016/06/15 08:36:26, Timothy ...
4 years, 6 months ago (2016-06-23 21:51:44 UTC) #8
Timothy Loh
lgtm https://codereview.chromium.org/2039093003/diff/240001/third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp File third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp (right): https://codereview.chromium.org/2039093003/diff/240001/third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp#newcode16 third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp:16: if (!value.isPrimitiveValue()) fwiw I think it'd clearer if ...
4 years, 5 months ago (2016-06-27 05:10:04 UTC) #9
meade_UTC10
https://codereview.chromium.org/2039093003/diff/240001/third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp File third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp (right): https://codereview.chromium.org/2039093003/diff/240001/third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp#newcode16 third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp:16: if (!value.isPrimitiveValue()) On 2016/06/27 05:10:04, Timothy Loh wrote: > ...
4 years, 5 months ago (2016-06-27 17:19:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2039093003/260001
4 years, 5 months ago (2016-06-27 19:25:04 UTC) #13
commit-bot: I haz the power
Committed patchset #14 (id:260001)
4 years, 5 months ago (2016-06-27 20:14:34 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 20:16:23 UTC) #17
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/8e8a560b7fe01f67f3a408e406948a4e3d5f37a1
Cr-Commit-Position: refs/heads/master@{#402267}

Powered by Google App Engine
This is Rietveld 408576698