ABANDONED: mash: Move shell delegate interfaces to ash/common

ABANDONED: mash: Move shell delegate interfaces to ash/common

These are dependencies of ash::ShellDelegate.

Moving them is a precondition for moving the mus implementations of them
from ash/sysui to ash/mus (since ash/mus can only depend on ash/common).

Also clean up a couple missing #includes of ash/shell.h in passing.

TODO: Deal with ash/system/tray/system_tray_delegate.h, which has many
dependencies of its own.

BUG=615155
TEST=compiles

[James Cook, 2016-06-06 23:26:04]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-06-06 23:26:05]

sky, please take a look. (Feel free to rubber-stamp if the move makes sense --
it's all mechanical.)

[James Cook, 2016-06-06 23:26:53]

Let me know if you'd like me to TBR these in the future.

[sky, 2016-06-06 23:29:09]

https://codereview.chromium.org/2048443002/diff/1/ash/common/session/session_...
File ash/common/session/session_state_delegate.h (right):

https://codereview.chromium.org/2048443002/diff/1/ash/common/session/session_...
ash/common/session/session_state_delegate.h:16: class Window;
Before you move this you need to remove the aura dep.
I was a bit hesitant to move the file over entirely as I suspect mash won't need
it all. But I realize it's easier to go down the move it all route, so lets do
that.

https://codereview.chromium.org/2048443002/diff/1/ash/common/session/session_...
ash/common/session/session_state_delegate.h:62: virtual ~SessionStateDelegate()
{};
nit: while you're here, nuke the ;

[James Cook, 2016-06-07 21:31:29]

Abandoning this CL because SessionStateDelegate and AccessibilityDelegate are
already moving over in other CLs.

I'll do a new one for the remaining delegates once those land.

[James Cook, 2016-06-07 21:31:59]

Description was changed from

==========
mash: Move shell delegate interfaces to ash/common

These are dependencies of ash::ShellDelegate.

Moving them is a precondition for moving the mus implementations of them
from ash/sysui to ash/mus (since ash/mus can only depend on ash/common).

Also clean up a couple missing #includes of ash/shell.h in passing.

TODO: Deal with ash/system/tray/system_tray_delegate.h, which has many
dependencies of its own.

BUG=615155
TEST=compiles
==========

to

==========
ABANDONED: mash: Move shell delegate interfaces to ash/common

These are dependencies of ash::ShellDelegate.

Moving them is a precondition for moving the mus implementations of them
from ash/sysui to ash/mus (since ash/mus can only depend on ash/common).

Also clean up a couple missing #includes of ash/shell.h in passing.

TODO: Deal with ash/system/tray/system_tray_delegate.h, which has many
dependencies of its own.

BUG=615155
TEST=compiles
==========

[James Cook, 2016-06-08 17:24:52]

jamescook@chromium.org changed reviewers:
- sky@chromium.org