Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 2046513003: mash: Move shelf model and item classes to ash/common/shelf (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@initshelfearly
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move shelf model and item classes to ash/common/shelf ShelfModel, ShelfItemDelegate and ShelfItemDelegate have no dependencies on ash::Shell, ash::RootWindowController or aura::Window so they can be moved as-is. No functional changes. BUG=615155 TEST=compiles Committed: https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e Cr-Commit-Position: refs/heads/master@{#398178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -1154 lines) Patch
M ash/accelerators/accelerator_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/ash.gyp View 4 chunks +9 lines, -9 lines 0 comments Download
A + ash/common/shelf/shelf_item_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/shelf/shelf_item_delegate_manager.h View 2 chunks +5 lines, -6 lines 0 comments Download
A + ash/common/shelf/shelf_item_delegate_manager.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A + ash/common/shelf/shelf_item_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/shelf/shelf_item_types.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/shelf/shelf_model.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/shelf/shelf_model.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A + ash/common/shelf/shelf_model_observer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/common/shelf/shelf_model_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/metrics/user_metrics_recorder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/app_list_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/app_list_shelf_item_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/app_list_shelf_item_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_button_pressed_metric_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
D ash/shelf/shelf_item_delegate.h View 1 chunk +0 lines, -80 lines 0 comments Download
D ash/shelf/shelf_item_delegate_manager.h View 1 chunk +0 lines, -85 lines 0 comments Download
D ash/shelf/shelf_item_delegate_manager.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D ash/shelf/shelf_item_types.h View 1 chunk +0 lines, -96 lines 0 comments Download
D ash/shelf/shelf_item_types.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D ash/shelf/shelf_model.h View 1 chunk +0 lines, -101 lines 0 comments Download
D ash/shelf/shelf_model.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D ash/shelf/shelf_model_observer.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ash/shelf/shelf_model_unittest.cc View 1 chunk +0 lines, -351 lines 0 comments Download
M ash/shelf/shelf_navigator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_navigator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_window_watcher_item_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_window_watcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/shell/window_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_watcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell/window_watcher_shelf_item_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/sysui/shelf_delegate_mus.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/test/shelf_item_delegate_manager_test_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/shelf_view_test_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/shelf_view_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shelf_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/test_shelf_item_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
James Cook
sky, please take a look. This is entirely mechanical, other than removing some unnecessary #includes ...
4 years, 6 months ago (2016-06-06 21:30:08 UTC) #2
sky
Rubber stamp LGTM
4 years, 6 months ago (2016-06-06 23:17:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046513003/1
4 years, 6 months ago (2016-06-06 23:22:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 00:52:59 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 00:54:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec04cc3ca7ac5354dd69fa39f149e92e6c19434e
Cr-Commit-Position: refs/heads/master@{#398178}

Powered by Google App Engine
This is Rietveld 408576698