Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2048033004: Revert of Convert startup_metric_utils to use mojo. (Closed)

Created:
4 years, 6 months ago by battre
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blundell+watchlist_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, droger+watchlist_chromium.org, jam, qsr+mojo_chromium.org, sdefresne+watchlist_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@message-mojom-magic
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert startup_metric_utils to use mojo. (patchset #6 id:240001 of https://codereview.chromium.org/2022413002/ ) Reason for revert: Breaks mac compilation. Original issue's description: > Convert startup_metric_utils to use mojo. > > BUG=577685 > TBR=jochen@chromium.org > > Committed: https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb > Cr-Commit-Position: refs/heads/master@{#398781} TBR=dcheng@chromium.org,erikchen@chromium.org,sky@chromium.org,jochen@chromium.org,sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=577685 Committed: https://crrev.com/95bd969a8e6fdabf9cc3926fd4f5031cdbfcb7d4 Cr-Commit-Position: refs/heads/master@{#398816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -163 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_exe.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_installer_util.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M components/crash.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/startup_metric_utils.gypi View 3 chunks +11 lines, -26 lines 0 comments Download
M components/startup_metric_utils/browser/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
M components/startup_metric_utils/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/startup_metric_utils/browser/startup_metric_host_impl.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/startup_metric_utils/browser/startup_metric_host_impl.cc View 1 chunk +0 lines, -26 lines 0 comments Download
A components/startup_metric_utils/browser/startup_metric_message_filter.h View 1 chunk +31 lines, -0 lines 0 comments Download
A components/startup_metric_utils/browser/startup_metric_message_filter.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M components/startup_metric_utils/common/BUILD.gn View 2 chunks +3 lines, -11 lines 0 comments Download
M components/startup_metric_utils/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
D components/startup_metric_utils/common/OWNERS View 1 chunk +0 lines, -13 lines 0 comments Download
D components/startup_metric_utils/common/startup_metric.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
A components/startup_metric_utils/common/startup_metric_message_generator.h View 1 chunk +7 lines, -0 lines 0 comments Download
A components/startup_metric_utils/common/startup_metric_message_generator.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A components/startup_metric_utils/common/startup_metric_messages.h View 1 chunk +13 lines, -0 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
battre
Created Revert of Convert startup_metric_utils to use mojo.
4 years, 6 months ago (2016-06-09 08:30:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048033004/1
4 years, 6 months ago (2016-06-09 08:30:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 08:32:18 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 08:33:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95bd969a8e6fdabf9cc3926fd4f5031cdbfcb7d4
Cr-Commit-Position: refs/heads/master@{#398816}

Powered by Google App Engine
This is Rietveld 408576698