Convert startup_metric_utils to use mojo.

Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org

Committed: https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb
Committed: https://crrev.com/33584452414612dd66a2fcc04cbd0a118d9fd64d
Cr-Original-Commit-Position: refs/heads/master@{#398781}
Cr-Commit-Position: refs/heads/master@{#398831}

[Sam McNally, 2016-06-01 02:53:41]

Patchset #2 (id:20001) has been deleted

[Sam McNally, 2016-06-01 02:53:49]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-06-06 04:01:17]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-06-06 04:01:28]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-06-06 04:01:36]

Patchset #1 (id:80001) has been deleted

[Sam McNally, 2016-06-07 00:16:10]

Patchset #1 (id:100001) has been deleted

[Sam McNally, 2016-06-07 03:24:57]

sammc@chromium.org changed reviewers:
+ erikchen@chromium.org

[erikchen, 2016-06-07 16:01:37]

Looks like the compile error is real?

https://codereview.chromium.org/2022413002/diff/120001/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (right):

https://codereview.chromium.org/2022413002/diff/120001/chrome/chrome_common.g...
chrome/chrome_common.gypi:516:
'<(DEPTH)/components/components.gyp:startup_metric_utils_common',
why do we need this on win, but not other OSes?

[Sam McNally, 2016-06-08 00:31:44]

On 2016/06/07 16:01:37, erikchen wrote:
> Looks like the compile error is real?
> 
Done.

https://codereview.chromium.org/2022413002/diff/120001/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (right):

https://codereview.chromium.org/2022413002/diff/120001/chrome/chrome_common.g...
chrome/chrome_common.gypi:516:
'<(DEPTH)/components/components.gyp:startup_metric_utils_common',
On 2016/06/07 16:01:37, erikchen wrote:
> why do we need this on win, but not other OSes?

startup_metric_utils_common used to contain the messages files, but now only
contains pre_read_field_trial_utils_win.* so is empty on platforms other than
Windows. Empty static_library targets don't work on Mac because libtool gets
upset. The workaround was to only use startup_metric_utils_common on Windows.

[erikchen, 2016-06-08 04:06:18]

lgtm

[Sam McNally, 2016-06-08 04:14:16]

sammc@chromium.org changed reviewers:
+ dcheng@chromium.org, sky@chromium.org

[Sam McNally, 2016-06-08 04:14:16]

+sky for chrome/

+dcheng for messages and mojom

[sky, 2016-06-08 16:19:47]

LGTM

https://codereview.chromium.org/2022413002/diff/140001/components/startup_met...
File components/startup_metric_utils.gypi (right):

https://codereview.chromium.org/2022413002/diff/140001/components/startup_met...
components/startup_metric_utils.gypi:50: 'target_name':
'startup_metric_utils_common',
I found reviewing the changes in the chrome side mildly confusing because of the
renames here. In particular as this is win only it would be better if it were
named as such, eg startup_metric_utils_win.

[dcheng, 2016-06-08 17:46:24]

https://codereview.chromium.org/2022413002/diff/140001/components/startup_met...
File components/startup_metric_utils/common/startup_metric.mojom (right):

https://codereview.chromium.org/2022413002/diff/140001/components/startup_met...
components/startup_metric_utils/common/startup_metric.mojom:11:
mojo.common.mojom.TimeTicks renderer_main_entry_time);
General question: how can we make it easy for developers to find the mojo struct
that wraps the C++ type they want to use? If I wasn't looking for TimeTicks, I
don't think I'd know to look here.

[Sam McNally, 2016-06-08 23:55:12]

Patchset #3 (id:160001) has been deleted

[Sam McNally, 2016-06-09 00:20:54]

https://codereview.chromium.org/2022413002/diff/140001/components/startup_met...
File components/startup_metric_utils.gypi (right):

https://codereview.chromium.org/2022413002/diff/140001/components/startup_met...
components/startup_metric_utils.gypi:50: 'target_name':
'startup_metric_utils_common',
On 2016/06/08 16:19:47, sky wrote:
> I found reviewing the changes in the chrome side mildly confusing because of
the
> renames here. In particular as this is win only it would be better if it were
> named as such, eg startup_metric_utils_win.

Done.

https://codereview.chromium.org/2022413002/diff/140001/components/startup_met...
File components/startup_metric_utils/common/startup_metric.mojom (right):

https://codereview.chromium.org/2022413002/diff/140001/components/startup_met...
components/startup_metric_utils/common/startup_metric.mojom:11:
mojo.common.mojom.TimeTicks renderer_main_entry_time);
On 2016/06/08 17:46:24, dcheng wrote:
> General question: how can we make it easy for developers to find the mojo
struct
> that wraps the C++ type they want to use? If I wasn't looking for TimeTicks, I
> don't think I'd know to look here.

If everything is typemapped, something like
git grep 'base::TimeTicks' -- '*.typemap'
should find the typemap and the mojo struct name. The typemap will contain the
path to the mojom containing the type.

[dcheng, 2016-06-09 00:25:40]

mojom lgtm

[Sam McNally, 2016-06-09 03:40:39]

Description was changed from

==========
Convert startup_metric_utils to use mojo.

BUG=577685
==========

to

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org,bradnelson@chromium.org
==========

[Sam McNally, 2016-06-09 03:40:39]

sammc@chromium.org changed reviewers:
+ bradnelson@chromium.org, jochen@chromium.org

[Sam McNally, 2016-06-09 03:43:05]

Description was changed from

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org,bradnelson@chromium.org
==========

to

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org
==========

[Sam McNally, 2016-06-09 03:43:05]

sammc@chromium.org changed reviewers:
- bradnelson@chromium.org

[Sam McNally, 2016-06-09 03:58:59]

TBR +jochen for components/crash.gypi and components/nacl.gyp.

[Sam McNally, 2016-06-09 03:59:13]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-06-09 03:59:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org, sky@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2022413002/#ps240001
(title: " ")

[commit-bot: I haz the power, 2016-06-09 03:59:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022413002/240001

[commit-bot: I haz the power, 2016-06-09 04:28:55]

Description was changed from

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org
==========

to

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org
==========

[commit-bot: I haz the power, 2016-06-09 04:28:57]

Committed patchset #6 (id:240001)

[commit-bot: I haz the power, 2016-06-09 04:30:16]

Description was changed from

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org
==========

to

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org

Committed: https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb
Cr-Commit-Position: refs/heads/master@{#398781}
==========

[commit-bot: I haz the power, 2016-06-09 04:30:17]

Patchset 6 (id:??) landed as
https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb
Cr-Commit-Position: refs/heads/master@{#398781}

[battre, 2016-06-09 08:30:41]

A revert of this CL (patchset #6 id:240001) has been created in
https://codereview.chromium.org/2048033004/ by battre@chromium.org.

The reason for reverting is: Breaks mac compilation..

[Sam McNally, 2016-06-09 09:21:44]

Description was changed from

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org

Committed: https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb
Cr-Commit-Position: refs/heads/master@{#398781}
==========

to

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org

Committed: https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb
Cr-Commit-Position: refs/heads/master@{#398781}
==========

[Sam McNally, 2016-06-09 09:38:39]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-06-09 09:38:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org, sky@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2022413002/#ps260001
(title: "only create the target startup_metric_utils_win on windows")

[commit-bot: I haz the power, 2016-06-09 09:39:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022413002/260001

[commit-bot: I haz the power, 2016-06-09 10:16:11]

Description was changed from

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org

Committed: https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb
Cr-Commit-Position: refs/heads/master@{#398781}
==========

to

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org

Committed: https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb
Cr-Commit-Position: refs/heads/master@{#398781}
==========

[commit-bot: I haz the power, 2016-06-09 10:16:13]

Committed patchset #7 (id:260001)

[commit-bot: I haz the power, 2016-06-09 10:17:44]

Description was changed from

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org

Committed: https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb
Cr-Commit-Position: refs/heads/master@{#398781}
==========

to

==========
Convert startup_metric_utils to use mojo.

BUG=577685
TBR=jochen@chromium.org

Committed: https://crrev.com/089f995b33d52e072a1a00c0302116fb9d4e49fb
Committed: https://crrev.com/33584452414612dd66a2fcc04cbd0a118d9fd64d
Cr-Original-Commit-Position: refs/heads/master@{#398781}
Cr-Commit-Position: refs/heads/master@{#398831}
==========

[commit-bot: I haz the power, 2016-06-09 10:17:46]

Patchset 7 (id:??) landed as
https://crrev.com/33584452414612dd66a2fcc04cbd0a118d9fd64d
Cr-Commit-Position: refs/heads/master@{#398831}