Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2048023005: Remove ObserveWheelEventAndResult callbacks since they are now gesture based. (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
Reviewers:
Charlie Reis, tdresser
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tdresser+watch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@can_scroll_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ObserveWheelEventAndResult callbacks since they are now gesture based. Remove unused code paths now that the scrolling via mouse wheel events has been torn out. BUG=598798 Committed: https://crrev.com/6b1c93bb8dc20575a1e72291825082277d0dc8e4 Cr-Commit-Position: refs/heads/master@{#400321}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -447 lines) Patch
M content/renderer/input/input_handler_manager.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/input/input_handler_manager.cc View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M content/renderer/input/render_widget_input_handler_delegate.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M ui/events/blink/input_scroll_elasticity_controller.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/events/blink/input_scroll_elasticity_controller.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M ui/events/blink/input_scroll_elasticity_controller_unittest.cc View 6 chunks +1 line, -291 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
dtapuska
4 years, 6 months ago (2016-06-09 20:17:39 UTC) #3
tdresser
LGTM!
4 years, 6 months ago (2016-06-09 20:43:24 UTC) #4
dtapuska
creis@chromium.org: Please review changes in content/*
4 years, 6 months ago (2016-06-16 06:25:38 UTC) #7
Charlie Reis
content/ LGTM.
4 years, 6 months ago (2016-06-16 21:59:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048023005/20001
4 years, 6 months ago (2016-06-16 22:32:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/82711) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-16 22:37:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048023005/40001
4 years, 6 months ago (2016-06-16 23:04:37 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-17 00:48:32 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 00:50:29 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6b1c93bb8dc20575a1e72291825082277d0dc8e4
Cr-Commit-Position: refs/heads/master@{#400321}

Powered by Google App Engine
This is Rietveld 408576698