Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Issue 2047963004: StructTraits optimizations (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, yzshen1
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

StructTraits optimizations Pass more things by const reference and read directly into output. BUG=611802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/605998f30d05bb8d323542c1039e64e1afce696b Cr-Commit-Position: refs/heads/master@{#398656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M cc/ipc/returned_resource_struct_traits.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/ipc/selection_struct_traits.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/ipc/shared_quad_state_struct_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/ipc/transferable_resource_struct_traits.h View 2 chunks +3 lines, -6 lines 0 comments Download
M gpu/ipc/common/mailbox_holder_struct_traits.h View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Fady Samuel
+yzshen@ for feedback. +tsepez@ for struct_traits OWNER
4 years, 6 months ago (2016-06-08 18:30:34 UTC) #4
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-08 18:48:29 UTC) #5
yzshen1
lgtm
4 years, 6 months ago (2016-06-08 19:08:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047963004/1
4 years, 6 months ago (2016-06-08 19:09:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 20:22:50 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 20:25:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/605998f30d05bb8d323542c1039e64e1afce696b
Cr-Commit-Position: refs/heads/master@{#398656}

Powered by Google App Engine
This is Rietveld 408576698