Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2124)

Unified Diff: cc/ipc/transferable_resource_struct_traits.h

Issue 2047963004: StructTraits optimizations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/ipc/shared_quad_state_struct_traits.h ('k') | gpu/ipc/common/mailbox_holder_struct_traits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/ipc/transferable_resource_struct_traits.h
diff --git a/cc/ipc/transferable_resource_struct_traits.h b/cc/ipc/transferable_resource_struct_traits.h
index 4e89d26d46d5eb8f7b2b31fa5bff970ee7b3c772..e5a269c6159e5d6ecb418c3c7ecc08c06c597960 100644
--- a/cc/ipc/transferable_resource_struct_traits.h
+++ b/cc/ipc/transferable_resource_struct_traits.h
@@ -29,7 +29,7 @@ struct StructTraits<cc::mojom::TransferableResource, cc::TransferableResource> {
return resource.size;
}
- static gpu::MailboxHolder mailbox_holder(
+ static const gpu::MailboxHolder& mailbox_holder(
const cc::TransferableResource& resource) {
return resource.mailbox_holder;
}
@@ -54,15 +54,12 @@ struct StructTraits<cc::mojom::TransferableResource, cc::TransferableResource> {
static bool Read(cc::mojom::TransferableResourceDataView data,
cc::TransferableResource* out) {
- gfx::Size size;
- gpu::MailboxHolder holder;
- if (!data.ReadSize(&size) || !data.ReadMailboxHolder(&holder))
+ if (!data.ReadSize(&out->size) ||
+ !data.ReadMailboxHolder(&out->mailbox_holder))
return false;
out->id = data.id();
out->format = static_cast<cc::ResourceFormat>(data.format());
out->filter = data.filter();
- out->size = size;
- out->mailbox_holder = holder;
out->read_lock_fences_enabled = data.read_lock_fences_enabled();
out->is_software = data.is_software();
out->gpu_memory_buffer_id.id = data.gpu_memory_buffer_id();
« no previous file with comments | « cc/ipc/shared_quad_state_struct_traits.h ('k') | gpu/ipc/common/mailbox_holder_struct_traits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698