Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: gpu/ipc/common/mailbox_holder_struct_traits.h

Issue 2047963004: StructTraits optimizations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/ipc/transferable_resource_struct_traits.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/ipc/common/mailbox_holder_struct_traits.h
diff --git a/gpu/ipc/common/mailbox_holder_struct_traits.h b/gpu/ipc/common/mailbox_holder_struct_traits.h
index 6f6f1464bfc2bcef84004275243fd09937dabdbb..5f000f5a796ad951d5626be336cd6cca5b627cb5 100644
--- a/gpu/ipc/common/mailbox_holder_struct_traits.h
+++ b/gpu/ipc/common/mailbox_holder_struct_traits.h
@@ -12,11 +12,11 @@ namespace mojo {
template <>
struct StructTraits<gpu::mojom::MailboxHolder, gpu::MailboxHolder> {
- static gpu::Mailbox mailbox(const gpu::MailboxHolder& holder) {
+ static const gpu::Mailbox& mailbox(const gpu::MailboxHolder& holder) {
return holder.mailbox;
}
- static gpu::SyncToken sync_token(const gpu::MailboxHolder& holder) {
+ static const gpu::SyncToken& sync_token(const gpu::MailboxHolder& holder) {
return holder.sync_token;
}
@@ -26,11 +26,10 @@ struct StructTraits<gpu::mojom::MailboxHolder, gpu::MailboxHolder> {
static bool Read(gpu::mojom::MailboxHolderDataView data,
gpu::MailboxHolder* out) {
- gpu::Mailbox mailbox;
- gpu::SyncToken sync_token;
- if (!data.ReadMailbox(&mailbox) || !data.ReadSyncToken(&sync_token))
+ if (!data.ReadMailbox(&out->mailbox) ||
+ !data.ReadSyncToken(&out->sync_token))
return false;
- *out = gpu::MailboxHolder(mailbox, sync_token, data.texture_target());
+ out->texture_target = data.texture_target();
return true;
}
};
« no previous file with comments | « cc/ipc/transferable_resource_struct_traits.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698