Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2047953002: Explicitly serialise platform file attachments instead of doing them implicitly as a mojo handle at… (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, erikchen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly serialise platform file attachments instead of doing them implicitly as a mojo handle attachment. This change is intended to make it clearer how platform file attachments are serialised and deserialised under ChannelMojo. BUG=604282 Committed: https://crrev.com/980a61bb07fd46b7a2446cff29d302f252efa2b4 Cr-Commit-Position: refs/heads/master@{#398765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M ipc/mojo/ipc.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 2 chunks +9 lines, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/mojo/ipc_mojo_handle_attachment.h View 2 chunks +4 lines, -9 lines 0 comments Download
M ipc/mojo/ipc_mojo_handle_attachment.cc View 2 chunks +2 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
Anand Mistry (off Chromium)
dcheng: For .mojom change and in case there are any security concerns because this changes ...
4 years, 6 months ago (2016-06-08 04:06:09 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-08 17:45:29 UTC) #4
dcheng
+tsepez, who knows much more about IPC attachments than I do
4 years, 6 months ago (2016-06-08 18:16:29 UTC) #6
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-08 18:28:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047953002/1
4 years, 6 months ago (2016-06-08 23:29:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 02:52:11 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 02:55:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/980a61bb07fd46b7a2446cff29d302f252efa2b4
Cr-Commit-Position: refs/heads/master@{#398765}

Powered by Google App Engine
This is Rietveld 408576698