Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2040383002: Use public handle API to transfer handle attachments. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo-handle-attachment
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use public handle API to transfer handle attachments. And remove embedder includes where not needed. BUG=604282 Committed: https://crrev.com/cbdbf182a62e9e1f5badbfa01ccfd074c36998ec Cr-Commit-Position: refs/heads/master@{#398779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -31 lines) Patch
M ipc/mojo/ipc_channel_mojo.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 6 chunks +46 lines, -27 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
Anand Mistry (off Chromium)
4 years, 6 months ago (2016-06-08 05:14:30 UTC) #2
Ken Rockot(use gerrit already)
lgtm, but you should also be remove ipc/mojo's dependency on mojo/edk/system now too.
4 years, 6 months ago (2016-06-08 17:46:18 UTC) #3
Ken Rockot(use gerrit already)
On 2016/06/08 at 17:46:18, Ken Rockot wrote: > lgtm, but you should also be remove ...
4 years, 6 months ago (2016-06-08 17:46:45 UTC) #4
Anand Mistry (off Chromium)
On 2016/06/08 17:46:45, Ken Rockot wrote: > On 2016/06/08 at 17:46:18, Ken Rockot wrote: > ...
4 years, 6 months ago (2016-06-08 21:36:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040383002/1
4 years, 6 months ago (2016-06-09 03:12:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 04:08:23 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 04:10:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbdbf182a62e9e1f5badbfa01ccfd074c36998ec
Cr-Commit-Position: refs/heads/master@{#398779}

Powered by Google App Engine
This is Rietveld 408576698