Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: ipc/mojo/ipc_mojo_handle_attachment.cc

Issue 2047953002: Explicitly serialise platform file attachments instead of doing them implicitly as a mojo handle at… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/mojo/ipc_mojo_handle_attachment.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/mojo/ipc_mojo_handle_attachment.cc
diff --git a/ipc/mojo/ipc_mojo_handle_attachment.cc b/ipc/mojo/ipc_mojo_handle_attachment.cc
index b2e16f121c5547030e58aaa06e871e7c7091f28e..8c22318f3d1ba977dcace71606dd16f8a50b3256 100644
--- a/ipc/mojo/ipc_mojo_handle_attachment.cc
+++ b/ipc/mojo/ipc_mojo_handle_attachment.cc
@@ -7,8 +7,6 @@
#include <utility>
#include "build/build_config.h"
-#include "ipc/ipc_message_attachment_set.h"
-#include "mojo/edk/embedder/embedder.h"
namespace IPC {
namespace internal {
@@ -25,15 +23,8 @@ MessageAttachment::Type MojoHandleAttachment::GetType() const {
#if defined(OS_POSIX)
base::PlatformFile MojoHandleAttachment::TakePlatformFile() {
- mojo::edk::ScopedPlatformHandle platform_handle;
- MojoResult unwrap_result = mojo::edk::PassWrappedPlatformHandle(
- handle_.release().value(), &platform_handle);
- if (unwrap_result != MOJO_RESULT_OK) {
- LOG(ERROR) << "Pipe failed to covert handles. Closing: " << unwrap_result;
- return -1;
- }
-
- return platform_handle.release().handle;
+ NOTREACHED();
+ return base::kInvalidPlatformFile;
}
#endif // OS_POSIX
« no previous file with comments | « ipc/mojo/ipc_mojo_handle_attachment.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698