third_party/WebKit/Source/core/animation/TimingInput.h - Issue 2047293002: Code cleanup: Replace Element with Document in element.animate()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/TimingInput.h

Issue 2047293002: Code cleanup: Replace Element with Document in element.animate() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_killForceConversionsToAnimatableValues

Patch Set: Fix unit test crash. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/StringKeyframe.cpp ('k') | third_party/WebKit/Source/core/animation/TimingInput.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/TimingInput.h

diff --git a/third_party/WebKit/Source/core/animation/TimingInput.h b/third_party/WebKit/Source/core/animation/TimingInput.h

index e72bc6a81f5c7cdc9edf3b6af905874b51eee1d8..ae091426305fb24106d4c610d2208c0a71efb5c4 100644

--- a/third_party/WebKit/Source/core/animation/TimingInput.h

+++ b/third_party/WebKit/Source/core/animation/TimingInput.h

@@ -20,7 +20,7 @@ class UnrestrictedDoubleOrString;

class CORE_EXPORT TimingInput {

STATIC_ONLY(TimingInput);

public:

- static bool convert(const KeyframeEffectOptions& timingInput, Timing& timingOutput, Document*, ExceptionState&);

+ static bool convert(const KeyframeEffectOptions& timingInput, Timing& timingOutput, Document&, ExceptionState&);

static bool convert(double duration, Timing& timingOutput, ExceptionState&);

static void setStartDelay(Timing&, double startDelay);

@@ -31,7 +31,7 @@ public:

static bool setIterationDuration(Timing&, const UnrestrictedDoubleOrString&, ExceptionState&);

static void setPlaybackRate(Timing&, double playbackRate);

static void setPlaybackDirection(Timing&, const String& direction);

- static bool setTimingFunction(Timing&, const String& timingFunctionString, Document*, ExceptionState&);

+ static bool setTimingFunction(Timing&, const String& timingFunctionString, Document&, ExceptionState&);

};

} // namespace blink