third_party/WebKit/Source/core/animation/TimingInput.cpp - Issue 2047293002: Code cleanup: Replace Element with Document in element.animate()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/TimingInput.cpp

Issue 2047293002: Code cleanup: Replace Element with Document in element.animate() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_killForceConversionsToAnimatableValues

Patch Set: Fix unit test crash. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/TimingInput.h ('k') | third_party/WebKit/Source/core/animation/TimingInputTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/TimingInput.cpp

diff --git a/third_party/WebKit/Source/core/animation/TimingInput.cpp b/third_party/WebKit/Source/core/animation/TimingInput.cpp

index e8f197e2f1a884ccb0fb265d13875a5b08ecaceb..43751f972ede1345835b793ec485695cc3e20973 100644

--- a/third_party/WebKit/Source/core/animation/TimingInput.cpp

+++ b/third_party/WebKit/Source/core/animation/TimingInput.cpp

@@ -106,7 +106,7 @@ void TimingInput::setPlaybackDirection(Timing& timing, const String& direction)

}

-bool TimingInput::setTimingFunction(Timing& timing, const String& timingFunctionString, Document* document, ExceptionState& exceptionState)

+bool TimingInput::setTimingFunction(Timing& timing, const String& timingFunctionString, Document& document, ExceptionState& exceptionState)

{

if (RefPtr<TimingFunction> timingFunction = AnimationInputHelpers::parseTimingFunction(timingFunctionString, document, exceptionState)) {

timing.timingFunction = timingFunction;

@@ -115,7 +115,7 @@ bool TimingInput::setTimingFunction(Timing& timing, const String& timingFunction

return false;

}

-bool TimingInput::convert(const KeyframeEffectOptions& timingInput, Timing& timingOutput, Document* document, ExceptionState& exceptionState)

+bool TimingInput::convert(const KeyframeEffectOptions& timingInput, Timing& timingOutput, Document& document, ExceptionState& exceptionState)

{

setStartDelay(timingOutput, timingInput.delay());

setEndDelay(timingOutput, timingInput.endDelay());