third_party/WebKit/Source/core/animation/StringKeyframe.cpp - Issue 2047293002: Code cleanup: Replace Element with Document in element.animate()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/StringKeyframe.cpp

Issue 2047293002: Code cleanup: Replace Element with Document in element.animate() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_killForceConversionsToAnimatableValues

Patch Set: Fix unit test crash. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/StringKeyframe.h ('k') | third_party/WebKit/Source/core/animation/TimingInput.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/StringKeyframe.cpp

diff --git a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

index 38296758381045959749d98612a984517dad80d0..9d92b9b68cbb141689c64f12f7d3bef18336cdd2 100644

--- a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

+++ b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

@@ -22,7 +22,7 @@ StringKeyframe::StringKeyframe(const StringKeyframe& copyFrom)

{

}

-void StringKeyframe::setCSSPropertyValue(CSSPropertyID property, const String& value, Element* element, StyleSheetContents* styleSheetContents)

+void StringKeyframe::setCSSPropertyValue(CSSPropertyID property, const String& value, StyleSheetContents* styleSheetContents)

{

ASSERT(property != CSSPropertyInvalid);

if (CSSAnimations::isAnimatableProperty(property))

@@ -36,7 +36,7 @@ void StringKeyframe::setCSSPropertyValue(CSSPropertyID property, CSSValue* value

m_cssPropertyMap->setProperty(property, value, false);

}

-void StringKeyframe::setPresentationAttributeValue(CSSPropertyID property, const String& value, Element* element, StyleSheetContents* styleSheetContents)

+void StringKeyframe::setPresentationAttributeValue(CSSPropertyID property, const String& value, StyleSheetContents* styleSheetContents)

{

ASSERT(property != CSSPropertyInvalid);

if (CSSAnimations::isAnimatableProperty(property))