Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/animation/TimingInputTest.cpp

Issue 2047293002: Code cleanup: Replace Element with Document in element.animate() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_killForceConversionsToAnimatableValues
Patch Set: Fix unit test crash. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/animation/TimingInput.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/TimingInputTest.cpp
diff --git a/third_party/WebKit/Source/core/animation/TimingInputTest.cpp b/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
index 694aa3de843eca47a37290537861c5123ad29139..7a61064bac7ce0864c14a26a5cda2781818292a0 100644
--- a/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
+++ b/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
@@ -14,27 +14,27 @@
namespace blink {
-Timing applyTimingInputNumber(v8::Isolate* isolate, String timingProperty, double timingPropertyValue, bool& timingConversionSuccess)
+Timing applyTimingInputNumber(V8TestingScope& scope, String timingProperty, double timingPropertyValue, bool& timingConversionSuccess)
{
- v8::Local<v8::Object> timingInput = v8::Object::New(isolate);
- setV8ObjectPropertyAsNumber(isolate, timingInput, timingProperty, timingPropertyValue);
+ v8::Local<v8::Object> timingInput = v8::Object::New(scope.isolate());
+ setV8ObjectPropertyAsNumber(scope.isolate(), timingInput, timingProperty, timingPropertyValue);
KeyframeEffectOptions timingInputDictionary;
TrackExceptionState exceptionState;
- V8KeyframeEffectOptions::toImpl(isolate, timingInput, timingInputDictionary, exceptionState);
+ V8KeyframeEffectOptions::toImpl(scope.isolate(), timingInput, timingInputDictionary, exceptionState);
Timing result;
- timingConversionSuccess = TimingInput::convert(timingInputDictionary, result, nullptr, exceptionState) && !exceptionState.hadException();
+ timingConversionSuccess = TimingInput::convert(timingInputDictionary, result, scope.document(), exceptionState) && !exceptionState.hadException();
return result;
}
-Timing applyTimingInputString(v8::Isolate* isolate, String timingProperty, String timingPropertyValue, bool& timingConversionSuccess)
+Timing applyTimingInputString(V8TestingScope& scope, String timingProperty, String timingPropertyValue, bool& timingConversionSuccess)
{
- v8::Local<v8::Object> timingInput = v8::Object::New(isolate);
- setV8ObjectPropertyAsString(isolate, timingInput, timingProperty, timingPropertyValue);
+ v8::Local<v8::Object> timingInput = v8::Object::New(scope.isolate());
+ setV8ObjectPropertyAsString(scope.isolate(), timingInput, timingProperty, timingPropertyValue);
KeyframeEffectOptions timingInputDictionary;
TrackExceptionState exceptionState;
- V8KeyframeEffectOptions::toImpl(isolate, timingInput, timingInputDictionary, exceptionState);
+ V8KeyframeEffectOptions::toImpl(scope.isolate(), timingInput, timingInputDictionary, exceptionState);
Timing result;
- timingConversionSuccess = TimingInput::convert(timingInputDictionary, result, nullptr, exceptionState) && !exceptionState.hadException();
+ timingConversionSuccess = TimingInput::convert(timingInputDictionary, result, scope.document(), exceptionState) && !exceptionState.hadException();
return result;
}
@@ -42,22 +42,22 @@ TEST(AnimationTimingInputTest, TimingInputStartDelay)
{
V8TestingScope scope;
bool ignoredSuccess;
- EXPECT_EQ(1.1, applyTimingInputNumber(scope.isolate(), "delay", 1100, ignoredSuccess).startDelay);
- EXPECT_EQ(-1, applyTimingInputNumber(scope.isolate(), "delay", -1000, ignoredSuccess).startDelay);
- EXPECT_EQ(1, applyTimingInputString(scope.isolate(), "delay", "1000", ignoredSuccess).startDelay);
- EXPECT_EQ(0, applyTimingInputString(scope.isolate(), "delay", "1s", ignoredSuccess).startDelay);
- EXPECT_EQ(0, applyTimingInputString(scope.isolate(), "delay", "Infinity", ignoredSuccess).startDelay);
- EXPECT_EQ(0, applyTimingInputString(scope.isolate(), "delay", "-Infinity", ignoredSuccess).startDelay);
- EXPECT_EQ(0, applyTimingInputString(scope.isolate(), "delay", "NaN", ignoredSuccess).startDelay);
- EXPECT_EQ(0, applyTimingInputString(scope.isolate(), "delay", "rubbish", ignoredSuccess).startDelay);
+ EXPECT_EQ(1.1, applyTimingInputNumber(scope, "delay", 1100, ignoredSuccess).startDelay);
+ EXPECT_EQ(-1, applyTimingInputNumber(scope, "delay", -1000, ignoredSuccess).startDelay);
+ EXPECT_EQ(1, applyTimingInputString(scope, "delay", "1000", ignoredSuccess).startDelay);
+ EXPECT_EQ(0, applyTimingInputString(scope, "delay", "1s", ignoredSuccess).startDelay);
+ EXPECT_EQ(0, applyTimingInputString(scope, "delay", "Infinity", ignoredSuccess).startDelay);
+ EXPECT_EQ(0, applyTimingInputString(scope, "delay", "-Infinity", ignoredSuccess).startDelay);
+ EXPECT_EQ(0, applyTimingInputString(scope, "delay", "NaN", ignoredSuccess).startDelay);
+ EXPECT_EQ(0, applyTimingInputString(scope, "delay", "rubbish", ignoredSuccess).startDelay);
}
TEST(AnimationTimingInputTest, TimingInputEndDelay)
{
V8TestingScope scope;
bool ignoredSuccess;
- EXPECT_EQ(10, applyTimingInputNumber(scope.isolate(), "endDelay", 10000, ignoredSuccess).endDelay);
- EXPECT_EQ(-2.5, applyTimingInputNumber(scope.isolate(), "endDelay", -2500, ignoredSuccess).endDelay);
+ EXPECT_EQ(10, applyTimingInputNumber(scope, "endDelay", 10000, ignoredSuccess).endDelay);
+ EXPECT_EQ(-2.5, applyTimingInputNumber(scope, "endDelay", -2500, ignoredSuccess).endDelay);
}
TEST(AnimationTimingInputTest, TimingInputFillMode)
@@ -66,36 +66,36 @@ TEST(AnimationTimingInputTest, TimingInputFillMode)
Timing::FillMode defaultFillMode = Timing::FillModeAuto;
bool ignoredSuccess;
- EXPECT_EQ(Timing::FillModeAuto, applyTimingInputString(scope.isolate(), "fill", "auto", ignoredSuccess).fillMode);
- EXPECT_EQ(Timing::FillModeForwards, applyTimingInputString(scope.isolate(), "fill", "forwards", ignoredSuccess).fillMode);
- EXPECT_EQ(Timing::FillModeNone, applyTimingInputString(scope.isolate(), "fill", "none", ignoredSuccess).fillMode);
- EXPECT_EQ(Timing::FillModeBackwards, applyTimingInputString(scope.isolate(), "fill", "backwards", ignoredSuccess).fillMode);
- EXPECT_EQ(Timing::FillModeBoth, applyTimingInputString(scope.isolate(), "fill", "both", ignoredSuccess).fillMode);
- EXPECT_EQ(defaultFillMode, applyTimingInputString(scope.isolate(), "fill", "everything!", ignoredSuccess).fillMode);
- EXPECT_EQ(defaultFillMode, applyTimingInputString(scope.isolate(), "fill", "backwardsandforwards", ignoredSuccess).fillMode);
- EXPECT_EQ(defaultFillMode, applyTimingInputNumber(scope.isolate(), "fill", 2, ignoredSuccess).fillMode);
+ EXPECT_EQ(Timing::FillModeAuto, applyTimingInputString(scope, "fill", "auto", ignoredSuccess).fillMode);
+ EXPECT_EQ(Timing::FillModeForwards, applyTimingInputString(scope, "fill", "forwards", ignoredSuccess).fillMode);
+ EXPECT_EQ(Timing::FillModeNone, applyTimingInputString(scope, "fill", "none", ignoredSuccess).fillMode);
+ EXPECT_EQ(Timing::FillModeBackwards, applyTimingInputString(scope, "fill", "backwards", ignoredSuccess).fillMode);
+ EXPECT_EQ(Timing::FillModeBoth, applyTimingInputString(scope, "fill", "both", ignoredSuccess).fillMode);
+ EXPECT_EQ(defaultFillMode, applyTimingInputString(scope, "fill", "everything!", ignoredSuccess).fillMode);
+ EXPECT_EQ(defaultFillMode, applyTimingInputString(scope, "fill", "backwardsandforwards", ignoredSuccess).fillMode);
+ EXPECT_EQ(defaultFillMode, applyTimingInputNumber(scope, "fill", 2, ignoredSuccess).fillMode);
}
TEST(AnimationTimingInputTest, TimingInputIterationStart)
{
V8TestingScope scope;
bool success;
- EXPECT_EQ(1.1, applyTimingInputNumber(scope.isolate(), "iterationStart", 1.1, success).iterationStart);
+ EXPECT_EQ(1.1, applyTimingInputNumber(scope, "iterationStart", 1.1, success).iterationStart);
EXPECT_TRUE(success);
- applyTimingInputNumber(scope.isolate(), "iterationStart", -1, success);
+ applyTimingInputNumber(scope, "iterationStart", -1, success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "iterationStart", "Infinity", success);
+ applyTimingInputString(scope, "iterationStart", "Infinity", success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "iterationStart", "-Infinity", success);
+ applyTimingInputString(scope, "iterationStart", "-Infinity", success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "iterationStart", "NaN", success);
+ applyTimingInputString(scope, "iterationStart", "NaN", success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "iterationStart", "rubbish", success);
+ applyTimingInputString(scope, "iterationStart", "rubbish", success);
EXPECT_FALSE(success);
}
@@ -103,24 +103,24 @@ TEST(AnimationTimingInputTest, TimingInputIterationCount)
{
V8TestingScope scope;
bool success;
- EXPECT_EQ(2.1, applyTimingInputNumber(scope.isolate(), "iterations", 2.1, success).iterationCount);
+ EXPECT_EQ(2.1, applyTimingInputNumber(scope, "iterations", 2.1, success).iterationCount);
EXPECT_TRUE(success);
- Timing timing = applyTimingInputString(scope.isolate(), "iterations", "Infinity", success);
+ Timing timing = applyTimingInputString(scope, "iterations", "Infinity", success);
EXPECT_TRUE(success);
EXPECT_TRUE(std::isinf(timing.iterationCount));
EXPECT_GT(timing.iterationCount, 0);
- applyTimingInputNumber(scope.isolate(), "iterations", -1, success);
+ applyTimingInputNumber(scope, "iterations", -1, success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "iterations", "-Infinity", success);
+ applyTimingInputString(scope, "iterations", "-Infinity", success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "iterations", "NaN", success);
+ applyTimingInputString(scope, "iterations", "NaN", success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "iterations", "rubbish", success);
+ applyTimingInputString(scope, "iterations", "rubbish", success);
EXPECT_FALSE(success);
}
@@ -128,30 +128,30 @@ TEST(AnimationTimingInputTest, TimingInputIterationDuration)
{
V8TestingScope scope;
bool success;
- EXPECT_EQ(1.1, applyTimingInputNumber(scope.isolate(), "duration", 1100, success).iterationDuration);
+ EXPECT_EQ(1.1, applyTimingInputNumber(scope, "duration", 1100, success).iterationDuration);
EXPECT_TRUE(success);
- Timing timing = applyTimingInputNumber(scope.isolate(), "duration", std::numeric_limits<double>::infinity(), success);
+ Timing timing = applyTimingInputNumber(scope, "duration", std::numeric_limits<double>::infinity(), success);
EXPECT_TRUE(success);
EXPECT_TRUE(std::isinf(timing.iterationDuration));
EXPECT_GT(timing.iterationDuration, 0);
- EXPECT_TRUE(std::isnan(applyTimingInputString(scope.isolate(), "duration", "auto", success).iterationDuration));
+ EXPECT_TRUE(std::isnan(applyTimingInputString(scope, "duration", "auto", success).iterationDuration));
EXPECT_TRUE(success);
- applyTimingInputString(scope.isolate(), "duration", "1000", success);
+ applyTimingInputString(scope, "duration", "1000", success);
EXPECT_FALSE(success);
- applyTimingInputNumber(scope.isolate(), "duration", -1000, success);
+ applyTimingInputNumber(scope, "duration", -1000, success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "duration", "-Infinity", success);
+ applyTimingInputString(scope, "duration", "-Infinity", success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "duration", "NaN", success);
+ applyTimingInputString(scope, "duration", "NaN", success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "duration", "rubbish", success);
+ applyTimingInputString(scope, "duration", "rubbish", success);
EXPECT_FALSE(success);
}
@@ -159,12 +159,12 @@ TEST(AnimationTimingInputTest, TimingInputPlaybackRate)
{
V8TestingScope scope;
bool ignoredSuccess;
- EXPECT_EQ(2.1, applyTimingInputNumber(scope.isolate(), "playbackRate", 2.1, ignoredSuccess).playbackRate);
- EXPECT_EQ(-1, applyTimingInputNumber(scope.isolate(), "playbackRate", -1, ignoredSuccess).playbackRate);
- EXPECT_EQ(1, applyTimingInputString(scope.isolate(), "playbackRate", "Infinity", ignoredSuccess).playbackRate);
- EXPECT_EQ(1, applyTimingInputString(scope.isolate(), "playbackRate", "-Infinity", ignoredSuccess).playbackRate);
- EXPECT_EQ(1, applyTimingInputString(scope.isolate(), "playbackRate", "NaN", ignoredSuccess).playbackRate);
- EXPECT_EQ(1, applyTimingInputString(scope.isolate(), "playbackRate", "rubbish", ignoredSuccess).playbackRate);
+ EXPECT_EQ(2.1, applyTimingInputNumber(scope, "playbackRate", 2.1, ignoredSuccess).playbackRate);
+ EXPECT_EQ(-1, applyTimingInputNumber(scope, "playbackRate", -1, ignoredSuccess).playbackRate);
+ EXPECT_EQ(1, applyTimingInputString(scope, "playbackRate", "Infinity", ignoredSuccess).playbackRate);
+ EXPECT_EQ(1, applyTimingInputString(scope, "playbackRate", "-Infinity", ignoredSuccess).playbackRate);
+ EXPECT_EQ(1, applyTimingInputString(scope, "playbackRate", "NaN", ignoredSuccess).playbackRate);
+ EXPECT_EQ(1, applyTimingInputString(scope, "playbackRate", "rubbish", ignoredSuccess).playbackRate);
}
TEST(AnimationTimingInputTest, TimingInputDirection)
@@ -173,12 +173,12 @@ TEST(AnimationTimingInputTest, TimingInputDirection)
Timing::PlaybackDirection defaultPlaybackDirection = Timing::PlaybackDirectionNormal;
bool ignoredSuccess;
- EXPECT_EQ(Timing::PlaybackDirectionNormal, applyTimingInputString(scope.isolate(), "direction", "normal", ignoredSuccess).direction);
- EXPECT_EQ(Timing::PlaybackDirectionReverse, applyTimingInputString(scope.isolate(), "direction", "reverse", ignoredSuccess).direction);
- EXPECT_EQ(Timing::PlaybackDirectionAlternate, applyTimingInputString(scope.isolate(), "direction", "alternate", ignoredSuccess).direction);
- EXPECT_EQ(Timing::PlaybackDirectionAlternateReverse, applyTimingInputString(scope.isolate(), "direction", "alternate-reverse", ignoredSuccess).direction);
- EXPECT_EQ(defaultPlaybackDirection, applyTimingInputString(scope.isolate(), "direction", "rubbish", ignoredSuccess).direction);
- EXPECT_EQ(defaultPlaybackDirection, applyTimingInputNumber(scope.isolate(), "direction", 2, ignoredSuccess).direction);
+ EXPECT_EQ(Timing::PlaybackDirectionNormal, applyTimingInputString(scope, "direction", "normal", ignoredSuccess).direction);
+ EXPECT_EQ(Timing::PlaybackDirectionReverse, applyTimingInputString(scope, "direction", "reverse", ignoredSuccess).direction);
+ EXPECT_EQ(Timing::PlaybackDirectionAlternate, applyTimingInputString(scope, "direction", "alternate", ignoredSuccess).direction);
+ EXPECT_EQ(Timing::PlaybackDirectionAlternateReverse, applyTimingInputString(scope, "direction", "alternate-reverse", ignoredSuccess).direction);
+ EXPECT_EQ(defaultPlaybackDirection, applyTimingInputString(scope, "direction", "rubbish", ignoredSuccess).direction);
+ EXPECT_EQ(defaultPlaybackDirection, applyTimingInputNumber(scope, "direction", 2, ignoredSuccess).direction);
}
TEST(AnimationTimingInputTest, TimingInputTimingFunction)
@@ -187,51 +187,52 @@ TEST(AnimationTimingInputTest, TimingInputTimingFunction)
const RefPtr<TimingFunction> defaultTimingFunction = LinearTimingFunction::shared();
bool success;
- EXPECT_EQ(*CubicBezierTimingFunction::preset(CubicBezierTimingFunction::EaseType::EASE), *applyTimingInputString(scope.isolate(), "easing", "ease", success).timingFunction);
+ EXPECT_EQ(*CubicBezierTimingFunction::preset(CubicBezierTimingFunction::EaseType::EASE), *applyTimingInputString(scope, "easing", "ease", success).timingFunction);
EXPECT_TRUE(success);
- EXPECT_EQ(*CubicBezierTimingFunction::preset(CubicBezierTimingFunction::EaseType::EASE_IN), *applyTimingInputString(scope.isolate(), "easing", "ease-in", success).timingFunction);
+ EXPECT_EQ(*CubicBezierTimingFunction::preset(CubicBezierTimingFunction::EaseType::EASE_IN), *applyTimingInputString(scope, "easing", "ease-in", success).timingFunction);
EXPECT_TRUE(success);
- EXPECT_EQ(*CubicBezierTimingFunction::preset(CubicBezierTimingFunction::EaseType::EASE_OUT), *applyTimingInputString(scope.isolate(), "easing", "ease-out", success).timingFunction);
+ EXPECT_EQ(*CubicBezierTimingFunction::preset(CubicBezierTimingFunction::EaseType::EASE_OUT), *applyTimingInputString(scope, "easing", "ease-out", success).timingFunction);
EXPECT_TRUE(success);
- EXPECT_EQ(*CubicBezierTimingFunction::preset(CubicBezierTimingFunction::EaseType::EASE_IN_OUT), *applyTimingInputString(scope.isolate(), "easing", "ease-in-out", success).timingFunction);
+ EXPECT_EQ(*CubicBezierTimingFunction::preset(CubicBezierTimingFunction::EaseType::EASE_IN_OUT), *applyTimingInputString(scope, "easing", "ease-in-out", success).timingFunction);
EXPECT_TRUE(success);
- EXPECT_EQ(*LinearTimingFunction::shared(), *applyTimingInputString(scope.isolate(), "easing", "linear", success).timingFunction);
+ EXPECT_EQ(*LinearTimingFunction::shared(), *applyTimingInputString(scope, "easing", "linear", success).timingFunction);
EXPECT_TRUE(success);
- EXPECT_EQ(*StepsTimingFunction::preset(StepsTimingFunction::StepPosition::START), *applyTimingInputString(scope.isolate(), "easing", "step-start", success).timingFunction);
+ EXPECT_EQ(*StepsTimingFunction::preset(StepsTimingFunction::StepPosition::START), *applyTimingInputString(scope, "easing", "step-start", success).timingFunction);
EXPECT_TRUE(success);
- EXPECT_EQ(*StepsTimingFunction::preset(StepsTimingFunction::StepPosition::MIDDLE), *applyTimingInputString(scope.isolate(), "easing", "step-middle", success).timingFunction);
+ EXPECT_EQ(*StepsTimingFunction::preset(StepsTimingFunction::StepPosition::MIDDLE), *applyTimingInputString(scope, "easing", "step-middle", success).timingFunction);
EXPECT_TRUE(success);
- EXPECT_EQ(*StepsTimingFunction::preset(StepsTimingFunction::StepPosition::END), *applyTimingInputString(scope.isolate(), "easing", "step-end", success).timingFunction);
+ EXPECT_EQ(*StepsTimingFunction::preset(StepsTimingFunction::StepPosition::END), *applyTimingInputString(scope, "easing", "step-end", success).timingFunction);
EXPECT_TRUE(success);
- EXPECT_EQ(*CubicBezierTimingFunction::create(1, 1, 0.3, 0.3), *applyTimingInputString(scope.isolate(), "easing", "cubic-bezier(1, 1, 0.3, 0.3)", success).timingFunction);
+ EXPECT_EQ(*CubicBezierTimingFunction::create(1, 1, 0.3, 0.3), *applyTimingInputString(scope, "easing", "cubic-bezier(1, 1, 0.3, 0.3)", success).timingFunction);
EXPECT_TRUE(success);
- EXPECT_EQ(*StepsTimingFunction::create(3, StepsTimingFunction::StepPosition::START), *applyTimingInputString(scope.isolate(), "easing", "steps(3, start)", success).timingFunction);
+ EXPECT_EQ(*StepsTimingFunction::create(3, StepsTimingFunction::StepPosition::START), *applyTimingInputString(scope, "easing", "steps(3, start)", success).timingFunction);
EXPECT_TRUE(success);
- EXPECT_EQ(*StepsTimingFunction::create(5, StepsTimingFunction::StepPosition::MIDDLE), *applyTimingInputString(scope.isolate(), "easing", "steps(5, middle)", success).timingFunction);
+ EXPECT_EQ(*StepsTimingFunction::create(5, StepsTimingFunction::StepPosition::MIDDLE), *applyTimingInputString(scope, "easing", "steps(5, middle)", success).timingFunction);
EXPECT_TRUE(success);
- EXPECT_EQ(*StepsTimingFunction::create(5, StepsTimingFunction::StepPosition::END), *applyTimingInputString(scope.isolate(), "easing", "steps(5, end)", success).timingFunction);
+ EXPECT_EQ(*StepsTimingFunction::create(5, StepsTimingFunction::StepPosition::END), *applyTimingInputString(scope, "easing", "steps(5, end)", success).timingFunction);
EXPECT_TRUE(success);
- applyTimingInputString(scope.isolate(), "easing", "", success);
+ applyTimingInputString(scope, "easing", "", success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "easing", "steps(5.6, end)", success);
+ applyTimingInputString(scope, "easing", "steps(5.6, end)", success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "easing", "cubic-bezier(2, 2, 0.3, 0.3)", success);
+ applyTimingInputString(scope, "easing", "cubic-bezier(2, 2, 0.3, 0.3)", success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "easing", "rubbish", success);
+ applyTimingInputString(scope, "easing", "rubbish", success);
EXPECT_FALSE(success);
- applyTimingInputNumber(scope.isolate(), "easing", 2, success);
+ applyTimingInputNumber(scope, "easing", 2, success);
EXPECT_FALSE(success);
- applyTimingInputString(scope.isolate(), "easing", "initial", success);
+ applyTimingInputString(scope, "easing", "initial", success);
EXPECT_FALSE(success);
}
TEST(AnimationTimingInputTest, TimingInputEmpty)
{
+ V8TestingScope scope;
TrackExceptionState exceptionState;
Timing controlTiming;
Timing updatedTiming;
- bool success = TimingInput::convert(KeyframeEffectOptions(), updatedTiming, nullptr, exceptionState);
+ bool success = TimingInput::convert(KeyframeEffectOptions(), updatedTiming, scope.document(), exceptionState);
EXPECT_TRUE(success);
EXPECT_FALSE(exceptionState.hadException());
« no previous file with comments | « third_party/WebKit/Source/core/animation/TimingInput.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698