Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2047003003: Rename MediaCodecBridge::Reset() to Flush() (Closed)

Created:
4 years, 6 months ago by watk
Modified:
4 years, 6 months ago
Reviewers:
DaleCurtis
CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-media_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename MediaCodecBridge::Reset() to Flush() MediaCodec has both a flush() and reset() but MediaCodecBridge::Reset() calls MediaCodec#flush(), which is a bit confusing, e.g., two of the call sites actually have a comment saying that Reset() calls flush(). BUG=618004 Committed: https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953 Cr-Commit-Position: refs/heads/master@{#398414}

Patch Set 1 #

Patch Set 2 : missed a couple #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -40 lines) Patch
M media/base/android/media_codec_bridge.h View 2 chunks +8 lines, -8 lines 0 comments Download
M media/base/android/media_codec_decoder.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M media/base/android/media_decoder_job.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/base/android/ndk_media_codec_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/ndk_media_codec_bridge.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M media/base/android/sdk_media_codec_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/sdk_media_codec_bridge.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M media/base/android/sdk_media_codec_bridge_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/android/media_codec_audio_decoder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
watk
Dale, since you +1000'd the bug, you win the honor of reviewing it :P timav, ...
4 years, 6 months ago (2016-06-07 17:36:38 UTC) #2
Tima Vaisburd
On 2016/06/07 17:36:38, watk wrote: > Dale, since you +1000'd the bug, you win the ...
4 years, 6 months ago (2016-06-07 17:39:43 UTC) #3
liberato (no reviews please)
On 2016/06/07 17:36:38, watk wrote: > Dale, since you +1000'd the bug, you win the ...
4 years, 6 months ago (2016-06-07 17:40:07 UTC) #4
DaleCurtis
lgtm
4 years, 6 months ago (2016-06-07 19:43:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047003003/20001
4 years, 6 months ago (2016-06-07 20:02:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 23:26:55 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 23:28:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab7d097a56f7cba3fa417b5ade22b71bcb4c1953
Cr-Commit-Position: refs/heads/master@{#398414}

Powered by Google App Engine
This is Rietveld 408576698