Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: media/base/android/media_codec_bridge.h

Issue 2047003003: Rename MediaCodecBridge::Reset() to Flush() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: missed a couple Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/android/media_codec_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_codec_bridge.h
diff --git a/media/base/android/media_codec_bridge.h b/media/base/android/media_codec_bridge.h
index 434f1806761705aa803a334caf1c390cdee24b45..892d9c713ef9e24e849c9e3ae454f0efbf1f107d 100644
--- a/media/base/android/media_codec_bridge.h
+++ b/media/base/android/media_codec_bridge.h
@@ -46,14 +46,6 @@ class MEDIA_EXPORT MediaCodecBridge {
public:
virtual ~MediaCodecBridge();
- // Resets both input and output, all indices previously returned in calls to
- // DequeueInputBuffer() and DequeueOutputBuffer() become invalid.
- // Please note that this clears all the inputs in the media codec. In other
- // words, there will be no outputs until new input is provided.
- // Returns MEDIA_CODEC_ERROR if an unexpected error happens, or MEDIA_CODEC_OK
- // otherwise.
- virtual MediaCodecStatus Reset() = 0;
-
// Calls start() against the media codec instance. Returns whether media
// codec was successfully started.
virtual bool Start() = 0;
@@ -65,6 +57,14 @@ class MEDIA_EXPORT MediaCodecBridge {
// instance -> StartAudio/Video() is recommended.
virtual void Stop() = 0;
+ // Calls flush() on the MediaCodec. All indices previously returned in calls
+ // to DequeueInputBuffer() and DequeueOutputBuffer() become invalid. Please
+ // note that this clears all the inputs in the media codec. In other words,
+ // there will be no outputs until new input is provided. Returns
+ // MEDIA_CODEC_ERROR if an unexpected error happens, or MEDIA_CODEC_OK
+ // otherwise.
+ virtual MediaCodecStatus Flush() = 0;
+
// Used for getting the output size. This is valid after DequeueInputBuffer()
// returns a format change by returning INFO_OUTPUT_FORMAT_CHANGED.
// Returns MEDIA_CODEC_ERROR if an error occurs, or MEDIA_CODEC_OK otherwise.
« no previous file with comments | « no previous file | media/base/android/media_codec_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698