media/filters/android/media_codec_audio_decoder.cc - Issue 2047003003: Rename MediaCodecBridge::Reset() to Flush()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/android/media_codec_audio_decoder.cc

Issue 2047003003: Rename MediaCodecBridge::Reset() to Flush() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed a couple Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/android/media_codec_audio_decoder.cc

diff --git a/media/filters/android/media_codec_audio_decoder.cc b/media/filters/android/media_codec_audio_decoder.cc

index d8f91dfda4cd091de88a9c0879f0ea012d83568f..9eefbcc32b35f1e4c793d71f34c63aa141e4650d 100644

--- a/media/filters/android/media_codec_audio_decoder.cc

+++ b/media/filters/android/media_codec_audio_decoder.cc

@@ -212,8 +212,7 @@ void MediaCodecAudioDecoder::Reset(const base::Closure& closure) {

bool success = false;

if (state_ != STATE_ERROR && state_ != STATE_DRAINED &&

base::android::BuildInfo::GetInstance()->sdk_int() >= 18) {

- // media_codec_->Reset() calls MediaCodec.flush().

- success = (media_codec_->Reset() == MEDIA_CODEC_OK);

+ success = (media_codec_->Flush() == MEDIA_CODEC_OK);

}

if (!success) {