Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2046973003: IntersectionObserver: throw exceptions as spec mandates. (Closed)

Created:
4 years, 6 months ago by szager1
Modified:
4 years, 6 months ago
Reviewers:
ikilpatrick, pdr., eae
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IntersectionObserver: throw exceptions as spec mandates. BUG=617396 R=eae@chromium.org,ikilpatrick@chromium.org Committed: https://crrev.com/fe5355eb33ecae91d4b92554a627a2677b7fbae9 Cr-Commit-Position: refs/heads/master@{#398640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions.html View 2 chunks +42 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.h View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 5 chunks +28 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/IntersectionObserverTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
szager1
4 years, 6 months ago (2016-06-07 21:13:28 UTC) #1
ikilpatrick
lgtm
4 years, 6 months ago (2016-06-07 21:30:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046973003/1
4 years, 6 months ago (2016-06-07 21:38:55 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/196570)
4 years, 6 months ago (2016-06-07 21:50:46 UTC) #6
szager1
4 years, 6 months ago (2016-06-08 17:16:09 UTC) #9
pdr.
On 2016/06/08 at 17:16:09, szager wrote: > LGTM
4 years, 6 months ago (2016-06-08 18:06:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046973003/1
4 years, 6 months ago (2016-06-08 18:12:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 19:29:10 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fe5355eb33ecae91d4b92554a627a2677b7fbae9 Cr-Commit-Position: refs/heads/master@{#398640}
4 years, 6 months ago (2016-06-08 19:31:10 UTC) #16
eae
4 years, 6 months ago (2016-06-09 07:08:39 UTC) #17
Message was sent while issue was closed.
LGTM post-facto

Powered by Google App Engine
This is Rietveld 408576698