Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions.html

Issue 2046973003: IntersectionObserver: throw exceptions as spec mandates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions.html
diff --git a/third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions.html b/third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions.html
index 1da557dd409739693a25bf3a4dd0e801d8d2203f..f811158727c921bb523b0a676b5f06835c16fdef 100644
--- a/third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions.html
+++ b/third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions.html
@@ -1,5 +1,6 @@
<!DOCTYPE html>
<div id="root"></div>
+<div id="target"></div>
<script src="../resources/js-test.js"></script>
<script src="../resources/gc.js"></script>
<script>
@@ -50,4 +51,45 @@
exc = e;
shouldBeType("exc", "TypeError");
}
+
+ observer = new IntersectionObserver(c => {}, {root: rootDiv});
+ rootDiv.parentNode.removeChild(rootDiv);
+ rootDiv = null;
+ gc();
+
+ try {
+ observer.observe(target);
+ testFailed("IntersectionObserver.observe() with a deleted root did not throw.");
+ } catch(e) {
+ exc = e;
+ shouldBeType("exc", "DOMException");
+ shouldBe("exc.code", "DOMException.INVALID_STATE_ERR");
+ }
+
+ try {
+ observer.unobserve(target);
+ testFailed("IntersectionObserver.unobserve() with a deleted root did not throw.");
+ } catch(e) {
+ exc = e;
+ shouldBeType("exc", "DOMException");
+ shouldBe("exc.code", "DOMException.INVALID_STATE_ERR");
+ }
+
+ try {
+ observer.disconnect();
+ testFailed("IntersectionObserver.disconnect() with a deleted root did not throw.");
+ } catch(e) {
+ exc = e;
+ shouldBeType("exc", "DOMException");
+ shouldBe("exc.code", "DOMException.INVALID_STATE_ERR");
+ }
+
+ try {
+ observer.takeRecords();
+ testFailed("IntersectionObserver.takeRecords() with a deleted root did not throw.");
+ } catch(e) {
+ exc = e;
+ shouldBeType("exc", "DOMException");
+ shouldBe("exc.code", "DOMException.INVALID_STATE_ERR");
+ }
</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698