third_party/WebKit/Source/core/dom/IntersectionObserver.h - Issue 2046973003: IntersectionObserver: throw exceptions as spec mandates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.h

Issue 2046973003: IntersectionObserver: throw exceptions as spec mandates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions-expected.txt ('k') | third_party/WebKit/Source/core/dom/IntersectionObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/IntersectionObserver.h

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.h b/third_party/WebKit/Source/core/dom/IntersectionObserver.h

index 469a0fa4ce2639ab255601b36dbb53cebaa1c4b7..ecf68c3c88f1a9575bc22476d4c0671976b3b6c8 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.h

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.h

@@ -29,10 +29,12 @@ public:

static void resumeSuspendedObservers();

// API methods

- void observe(Element*);

- void unobserve(Element*);

- void disconnect();

- HeapVector<Member<IntersectionObserverEntry>> takeRecords();

+ void observe(Element*, ExceptionState&);

+ void unobserve(Element*, ExceptionState&);

+ void disconnect(ExceptionState&);

+ HeapVector<Member<IntersectionObserverEntry>> takeRecords(ExceptionState&);

+ // API attributes

Element* root() const;

String rootMargin() const;

const Vector<float>& thresholds() const { return m_thresholds; }