Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2041583004: mash: Move WmShelfAura ownership to RootWindowController and init it earlier (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@moveshelftypes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move WmShelfAura ownership to RootWindowController and init it earlier This will allow it to be used in status tray initialization code. In particular: * It can wrap actions handled by ShelfWidget and ShelfLayoutManager (e.g. GetAutoHideState) * It can have observers similar to ShelfLayoutManagerObserver (OnAutoHideStateChanged) It's also more similar to how ash::mus::RootWindowController owns WmShelfMus. BUG=615155 TEST=ash_unittests Committed: https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f Cr-Commit-Position: refs/heads/master@{#398105}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -29 lines) Patch
M ash/aura/wm_root_window_controller_aura.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/aura/wm_shelf_aura.h View 1 2 chunks +16 lines, -5 lines 0 comments Download
M ash/aura/wm_shelf_aura.cc View 3 chunks +28 lines, -8 lines 0 comments Download
M ash/common/wm/workspace/workspace_layout_manager_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/root_window_controller.h View 4 chunks +9 lines, -0 lines 0 comments Download
M ash/root_window_controller.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M ash/shelf/shelf.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M ash/shelf/shelf.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M ash/shelf/shelf_widget.h View 2 chunks +2 lines, -1 line 0 comments Download
M ash/shelf/shelf_widget.cc View 2 chunks +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
James Cook
sky, please take a look. I'm planning to continue using WmShelf as the "public interface" ...
4 years, 6 months ago (2016-06-06 17:42:50 UTC) #4
sky
LGTM
4 years, 6 months ago (2016-06-06 19:02:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041583004/20001
4 years, 6 months ago (2016-06-06 20:03:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 20:09:07 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 20:10:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be6ed82face2a9d329cd9f6309266958a3948b3f
Cr-Commit-Position: refs/heads/master@{#398105}

Powered by Google App Engine
This is Rietveld 408576698