Implement DelegationTracker for tracking delegated permissions to RenderFrameHosts

Implement DelegationTracker for tracking delegated permissions to RenderFrameHosts

DelegationTracker maintains a browser-side mapping of which frames have
delegated permissions to other frames. It also allows querying whether a
permission has actually been granted to a frame based on permissions that have
been delegated in the tree of frames and based on the origins of the frames
involved.

For each child RenderFrameHost that permissions are set for, an entry is
added to a map. That entry is removed when the RenderFrameHost is destroyed
or navigated such that permissions will no longer be delegated to it.

A MockRenderFrameHost has been introduced to aid testing.

BUG=614608
Committed: https://crrev.com/7c1c35a23e257dc27e32827500bf9ca56510df89
Cr-Commit-Position: refs/heads/master@{#401478}

[raymes, 2016-06-08 04:07:38]

Description was changed from

==========
Implement DelegationTracker for tracking delegated permissions to
RenderFrameHosts

DelegationTracker maintains a browser-side mapping of which frames have
delegated permissions to other frames. It also allows querying whether a
permission has actually been granted to a frame based on permissions that have
been delegated in the tree of frames and based on the origins of the frames
involved.

A MockRenderFrameHost has been introduced to aid testing.

BUG=614608
==========

to

==========
Implement DelegationTracker for tracking delegated permissions to
RenderFrameHosts

DelegationTracker maintains a browser-side mapping of which frames have
delegated permissions to other frames. It also allows querying whether a
permission has actually been granted to a frame based on permissions that have
been delegated in the tree of frames and based on the origins of the frames
involved.

For each child RenderFrameHost that permissions are set for, an entry is
added to a map. That entry is removed when the RenderFrameHost is destroyed
or navigated such that permissions will no longer be delegated to it.

A MockRenderFrameHost has been introduced to aid testing.

BUG=614608
==========

[raymes, 2016-06-09 05:46:43]

raymes@chromium.org changed reviewers:
+ palmer@chromium.org

[palmer, 2016-06-10 19:35:24]

lgtm

https://codereview.chromium.org/2046293002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/delegation_tracker.cc (right):

https://codereview.chromium.org/2046293002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/delegation_tracker.cc:38:
rfh_destroyed_callback_.Run(render_frame_host);  // Will delete "this".
Nit: |this|.

[raymes, 2016-06-16 04:55:53]

raymes@chromium.org changed reviewers:
+ creis@chromium.org

[raymes, 2016-06-16 04:55:54]

creis: please let me know if the changes to content/ seem ok to you. Thanks!

https://codereview.chromium.org/2046293002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/delegation_tracker.cc (right):

https://codereview.chromium.org/2046293002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/delegation_tracker.cc:38:
rfh_destroyed_callback_.Run(render_frame_host);  // Will delete "this".
On 2016/06/10 19:35:24, palmer wrote:
> Nit: |this|.

Done.

[Charlie Reis, 2016-06-16 22:03:05]

https://codereview.chromium.org/2046293002/diff/50001/content/public/test/moc...
File content/public/test/mock_render_frame_host.h (right):

https://codereview.chromium.org/2046293002/diff/50001/content/public/test/moc...
content/public/test/mock_render_frame_host.h:14: class CONTENT_EXPORT
MockRenderFrameHost : public RenderFrameHost {
We already have RenderFrameHostTester (which is tied with TestRenderFrameHost),
so I don't think we should need another MockRenderFrameHost.  Is there a reason
the existing class doesn't work?  (I agree it's a bit hard to discover.)

[raymes, 2016-06-20 06:35:48]

https://codereview.chromium.org/2046293002/diff/50001/content/public/test/moc...
File content/public/test/mock_render_frame_host.h (right):

https://codereview.chromium.org/2046293002/diff/50001/content/public/test/moc...
content/public/test/mock_render_frame_host.h:14: class CONTENT_EXPORT
MockRenderFrameHost : public RenderFrameHost {
On 2016/06/16 22:03:05, Charlie Reis (OOO til June 18) wrote:
> We already have RenderFrameHostTester (which is tied with
TestRenderFrameHost),
> so I don't think we should need another MockRenderFrameHost.  Is there a
reason
> the existing class doesn't work?  (I agree it's a bit hard to discover.)

Ah thanks for the pointer! That made things much nicer anyway. I've removed this
class but I needed to make a small fix. PTAL.

[Charlie Reis, 2016-06-20 21:34:21]

Great!  One other note on PermissionTypeHash below (sorry for not noticing it
before).

https://codereview.chromium.org/2046293002/diff/90001/content/public/browser/...
File content/public/browser/permission_type.h (right):

https://codereview.chromium.org/2046293002/diff/90001/content/public/browser/...
content/public/browser/permission_type.h:31: struct PermissionTypeHash {
This should stay outside content/ unless something within content/ uses it.  

See https://www.chromium.org/developers/content-module/content-api:
"all classes/structs/enums in the public API must be used by embedders and
content. i.e. if the chrome layer uses a struct but content doesn't know about
it, it doesn't belong in content/public but instead some module that's higher
level."

https://codereview.chromium.org/2046293002/diff/90001/content/test/test_rende...
File content/test/test_render_frame_host.cc (right):

https://codereview.chromium.org/2046293002/diff/90001/content/test/test_rende...
content/test/test_render_frame_host.cc:135: params.origin = url::Origin(url);
Ah, interesting.  Yeah, seems like an oversight to not assign params.origin, and
this is the best we can do given only the GURL.  Seems reasonable to me if the
existing tests continue to pass.

[raymes, 2016-06-22 03:44:48]

Patchset #7 (id:110001) has been deleted

[raymes, 2016-06-22 03:47:56]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[raymes, 2016-06-22 03:48:11]

Thanks! I moved it back into chrome/

https://codereview.chromium.org/2046293002/diff/90001/content/public/browser/...
File content/public/browser/permission_type.h (right):

https://codereview.chromium.org/2046293002/diff/90001/content/public/browser/...
content/public/browser/permission_type.h:31: struct PermissionTypeHash {
On 2016/06/20 21:34:21, Charlie Reis wrote:
> This should stay outside content/ unless something within content/ uses it.  
> 
> See https://www.chromium.org/developers/content-module/content-api:
> "all classes/structs/enums in the public API must be used by embedders and
> content. i.e. if the chrome layer uses a struct but content doesn't know about
> it, it doesn't belong in content/public but instead some module that's higher
> level."

Done.

[commit-bot: I haz the power, 2016-06-22 03:48:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046293002/130001

[commit-bot: I haz the power, 2016-06-22 04:30:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 04:30:11]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-06-22 16:11:49]

Thanks!  content/ LGTM.

[raymes, 2016-06-23 00:14:40]

The CQ bit was checked by raymes@chromium.org

[raymes, 2016-06-23 00:14:40]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org
Link to the patchset: https://codereview.chromium.org/2046293002/#ps130001
(title: "Implement DelegationTracker for tracking delegated permissions to
RenderFrameHosts")

[commit-bot: I haz the power, 2016-06-23 00:15:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046293002/130001

[commit-bot: I haz the power, 2016-06-23 00:21:13]

Description was changed from

==========
Implement DelegationTracker for tracking delegated permissions to
RenderFrameHosts

DelegationTracker maintains a browser-side mapping of which frames have
delegated permissions to other frames. It also allows querying whether a
permission has actually been granted to a frame based on permissions that have
been delegated in the tree of frames and based on the origins of the frames
involved.

For each child RenderFrameHost that permissions are set for, an entry is
added to a map. That entry is removed when the RenderFrameHost is destroyed
or navigated such that permissions will no longer be delegated to it.

A MockRenderFrameHost has been introduced to aid testing.

BUG=614608
==========

to

==========
Implement DelegationTracker for tracking delegated permissions to
RenderFrameHosts

DelegationTracker maintains a browser-side mapping of which frames have
delegated permissions to other frames. It also allows querying whether a
permission has actually been granted to a frame based on permissions that have
been delegated in the tree of frames and based on the origins of the frames
involved.

For each child RenderFrameHost that permissions are set for, an entry is
added to a map. That entry is removed when the RenderFrameHost is destroyed
or navigated such that permissions will no longer be delegated to it.

A MockRenderFrameHost has been introduced to aid testing.

BUG=614608
==========

[commit-bot: I haz the power, 2016-06-23 00:21:14]

Committed patchset #7 (id:130001)

[commit-bot: I haz the power, 2016-06-23 00:22:48]

Description was changed from

==========
Implement DelegationTracker for tracking delegated permissions to
RenderFrameHosts

DelegationTracker maintains a browser-side mapping of which frames have
delegated permissions to other frames. It also allows querying whether a
permission has actually been granted to a frame based on permissions that have
been delegated in the tree of frames and based on the origins of the frames
involved.

For each child RenderFrameHost that permissions are set for, an entry is
added to a map. That entry is removed when the RenderFrameHost is destroyed
or navigated such that permissions will no longer be delegated to it.

A MockRenderFrameHost has been introduced to aid testing.

BUG=614608
==========

to

==========
Implement DelegationTracker for tracking delegated permissions to
RenderFrameHosts

DelegationTracker maintains a browser-side mapping of which frames have
delegated permissions to other frames. It also allows querying whether a
permission has actually been granted to a frame based on permissions that have
been delegated in the tree of frames and based on the origins of the frames
involved.

For each child RenderFrameHost that permissions are set for, an entry is
added to a map. That entry is removed when the RenderFrameHost is destroyed
or navigated such that permissions will no longer be delegated to it.

A MockRenderFrameHost has been introduced to aid testing.

BUG=614608

Committed: https://crrev.com/7c1c35a23e257dc27e32827500bf9ca56510df89
Cr-Commit-Position: refs/heads/master@{#401478}
==========

[commit-bot: I haz the power, 2016-06-23 00:22:50]

Patchset 7 (id:??) landed as
https://crrev.com/7c1c35a23e257dc27e32827500bf9ca56510df89
Cr-Commit-Position: refs/heads/master@{#401478}