Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/permissions/delegation_tracker.cc

Issue 2046293002: Implement DelegationTracker for tracking delegated permissions to RenderFrameHosts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-delegation-2-blink
Patch Set: Implement DelegationTracker for tracking delegated permissions to RenderFrameHosts Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/permissions/delegation_tracker.h"
6
7 #include <unordered_set>
8
9 #include "base/memory/ptr_util.h"
10 #include "chrome/browser/permissions/permission_util.h"
11 #include "content/public/browser/permission_type.h"
12 #include "content/public/browser/render_frame_host.h"
13 #include "content/public/browser/web_contents.h"
14 #include "content/public/browser/web_contents_observer.h"
15
16 class DelegationTracker::DelegatedForChild : content::WebContentsObserver {
17 public:
18 DelegatedForChild(content::RenderFrameHost* child_rfh,
19 const std::vector<content::PermissionType>& permissions,
20 const base::Callback<void(content::RenderFrameHost*)>&
21 rfh_destroyed_callback)
22 : content::WebContentsObserver(
23 content::WebContents::FromRenderFrameHost(child_rfh)),
24 child_rfh_(child_rfh),
25 permissions_(permissions.begin(), permissions.end()),
26 rfh_destroyed_callback_(rfh_destroyed_callback) {}
27
28 ~DelegatedForChild() override {}
29
30 bool HasPermission(const content::PermissionType& permission) {
31 return permissions_.count(permission) == 1;
32 }
33
34 private:
35 DISALLOW_COPY_AND_ASSIGN(DelegatedForChild);
36
37 void ClearPermissions(content::RenderFrameHost* render_frame_host) {
38 if (render_frame_host == child_rfh_)
39 rfh_destroyed_callback_.Run(render_frame_host); // Will delete |this|.
40 }
41
42 // WebContentsObserver
43 void RenderFrameHostChanged(content::RenderFrameHost* old_host,
44 content::RenderFrameHost* new_host) override {
45 ClearPermissions(old_host);
46 }
47
48 void FrameDeleted(content::RenderFrameHost* render_frame_host) override {
49 ClearPermissions(render_frame_host);
50 }
51
52 void DidNavigateAnyFrame(
53 content::RenderFrameHost* render_frame_host,
54 const content::LoadCommittedDetails& details,
55 const content::FrameNavigateParams& params) override {
56 ClearPermissions(render_frame_host);
57 }
58
59 content::RenderFrameHost* child_rfh_;
60
61 std::unordered_set<content::PermissionType, PermissionTypeHash> permissions_;
62
63 base::Callback<void(content::RenderFrameHost*)> rfh_destroyed_callback_;
64 };
65
66 DelegationTracker::DelegationTracker() {}
67
68 DelegationTracker::~DelegationTracker() {}
69
70 void DelegationTracker::SetDelegatedPermissions(
71 content::RenderFrameHost* child_rfh,
72 const std::vector<content::PermissionType>& permissions) {
73 DCHECK(child_rfh && child_rfh->GetParent());
74 delegated_permissions_[child_rfh] = base::WrapUnique(new DelegatedForChild(
75 child_rfh, permissions,
76 base::Bind(&DelegationTracker::RenderFrameHostChanged,
77 base::Unretained(this))));
78 }
79
80 bool DelegationTracker::IsGranted(content::RenderFrameHost* requesting_rfh,
81 const content::PermissionType& permission) {
82 content::RenderFrameHost* child_rfh = requesting_rfh;
83 while (child_rfh->GetParent()) {
84 // Parents with unique origins can't delegate permission.
85 url::Origin parent_origin =
86 child_rfh->GetParent()->GetLastCommittedOrigin();
87 if (parent_origin.unique())
88 return false;
89
90 if (!child_rfh->GetLastCommittedOrigin().IsSameOriginWith(parent_origin)) {
91 const auto& it = delegated_permissions_.find(child_rfh);
92 if (it == delegated_permissions_.end())
93 return false;
94 if (!it->second->HasPermission(permission))
95 return false;
96 }
97 child_rfh = child_rfh->GetParent();
98 }
99 return true;
100 }
101
102 void DelegationTracker::RenderFrameHostChanged(content::RenderFrameHost* rfh) {
103 delegated_permissions_.erase(rfh);
104 }
OLDNEW
« no previous file with comments | « chrome/browser/permissions/delegation_tracker.h ('k') | chrome/browser/permissions/delegation_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698