Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/permissions/delegation_tracker.cc

Issue 2046293002: Implement DelegationTracker for tracking delegated permissions to RenderFrameHosts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-delegation-2-blink
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/permissions/delegation_tracker.h"
6
7 #include <unordered_set>
8
9 #include "base/memory/ptr_util.h"
10 #include "content/public/browser/permission_type.h"
11 #include "content/public/browser/render_frame_host.h"
12 #include "content/public/browser/web_contents.h"
13 #include "content/public/browser/web_contents_observer.h"
14
15 class DelegationTracker::DelegatedForChild : content::WebContentsObserver {
16 public:
17 DelegatedForChild(content::RenderFrameHost* child_rfh,
18 content::WebContents* web_contents,
19 const std::vector<content::PermissionType>& permissions,
20 const base::Callback<void(content::RenderFrameHost*)>&
21 rfh_destroyed_callback)
22 : content::WebContentsObserver(web_contents),
23 child_rfh_(child_rfh),
24 permissions_(permissions.begin(), permissions.end()),
25 rfh_destroyed_callback_(rfh_destroyed_callback) {}
26
27 ~DelegatedForChild() override {}
28
29 bool HasPermission(const content::PermissionType& permission) {
30 return permissions_.count(permission) == 1;
31 }
32
33 private:
34 DISALLOW_COPY_AND_ASSIGN(DelegatedForChild);
35
36 void ClearPermissions(content::RenderFrameHost* render_frame_host) {
37 if (render_frame_host == child_rfh_)
38 rfh_destroyed_callback_.Run(render_frame_host); // Will delete "this".
palmer 2016/06/10 19:35:24 Nit: |this|.
raymes 2016/06/16 04:55:53 Done.
39 }
40
41 // WebContentsObserver
42 void RenderFrameHostChanged(content::RenderFrameHost* old_host,
43 content::RenderFrameHost* new_host) override {
44 ClearPermissions(old_host);
45 }
46
47 void FrameDeleted(content::RenderFrameHost* render_frame_host) override {
48 ClearPermissions(render_frame_host);
49 }
50
51 void DidNavigateAnyFrame(
52 content::RenderFrameHost* render_frame_host,
53 const content::LoadCommittedDetails& details,
54 const content::FrameNavigateParams& params) override {
55 ClearPermissions(render_frame_host);
56 }
57
58 content::RenderFrameHost* child_rfh_;
59
60 std::unordered_set<content::PermissionType, content::PermissionTypeHash>
61 permissions_;
62
63 base::Callback<void(content::RenderFrameHost*)> rfh_destroyed_callback_;
64 };
65
66 DelegationTracker::DelegationTracker() {}
67
68 DelegationTracker::~DelegationTracker() {}
69
70 void DelegationTracker::SetDelegatedPermissions(
71 content::RenderFrameHost* child_rfh,
72 const std::vector<content::PermissionType>& permissions) {
73 SetDelegatedPermissionsInternal(
74 child_rfh, content::WebContents::FromRenderFrameHost(child_rfh),
75 permissions);
76 }
77
78 bool DelegationTracker::IsGranted(content::RenderFrameHost* requesting_rfh,
79 const content::PermissionType& permission) {
80 content::RenderFrameHost* child_rfh = requesting_rfh;
81 while (child_rfh->GetParent()) {
82 if (!child_rfh->GetLastCommittedOrigin().IsSameOriginWith(
83 child_rfh->GetParent()->GetLastCommittedOrigin())) {
84 const auto& it = delegated_permissions_.find(child_rfh);
85 if (it == delegated_permissions_.end())
86 return false;
87 if (!it->second->HasPermission(permission))
88 return false;
89 }
90 child_rfh = child_rfh->GetParent();
91 }
92 return true;
93 }
94
95 void DelegationTracker::SetDelegatedPermissionsInternal(
96 content::RenderFrameHost* child_rfh,
97 content::WebContents* web_contents,
98 const std::vector<content::PermissionType>& permissions) {
99 DCHECK(child_rfh && child_rfh->GetParent());
100 delegated_permissions_[child_rfh] = base::WrapUnique(new DelegatedForChild(
101 child_rfh, web_contents, permissions,
102 base::Bind(&DelegationTracker::RenderFrameHostChanged,
103 base::Unretained(this))));
104 }
105
106 void DelegationTracker::RenderFrameHostChanged(content::RenderFrameHost* rfh) {
107 delegated_permissions_.erase(rfh);
108 }
OLDNEW
« no previous file with comments | « chrome/browser/permissions/delegation_tracker.h ('k') | chrome/browser/permissions/delegation_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698