Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2045843002: Move console error detection in browser tests to higher level (Closed)

Created:
4 years, 6 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@ftp-error
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move console error detection in browser tests to higher level This is because there are JavaScript-based browser tests that aren't WebUI-specific. Also, figure out a way to integrate with: https://codereview.chromium.org/2013573007/#msg14 I proposed to mmenke@ that we change: void logging::SetLogMessageHandler(...handler..); to scoped_ptr<ListenerHandle> logging::AddLogMessageListener(...listener...); This would be a semantic change for some existing consumers, but they all seem to only want to listen to the contents and not actually handle them. This would also allow logging to remain unchanged and remove global overriding, which may have unexpected side-effects. BUG=615626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -29 lines) Patch
M chrome/browser/net/ftp_browsertest.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/test/base/javascript_browser_test.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/test/base/javascript_browser_test.cc View 4 chunks +46 lines, -0 lines 0 comments Download
M chrome/test/base/web_ui_browser_test.cc View 6 chunks +5 lines, -27 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 1 (1 generated)
Dan Beam
4 years, 3 months ago (2016-09-15 21:24:44 UTC) #1
Description was changed from

==========
Move console error detection in browser tests to higher level

This is because there are JavaScript-based browser tests that aren't
WebUI-specific.

Also, figure out a way to integrate with:
https://codereview.chromium.org/2013573007/#msg14

I proposed to mmenke@ that we change:

  void logging::SetLogMessageHandler(...handler..);

to

  scoped_ptr<ListenerHandle> logging::AddLogMessageListener(...listener...);

This would be a semantic change for some existing consumers, but they all
seem to only want to listen to the contents and not actually handle them.

This would also allow logging to remain unchanged and remove global
overriding, which may have unexpected side-effects.

BUG=615626
==========

to

==========
Move console error detection in browser tests to higher level

This is because there are JavaScript-based browser tests that aren't
WebUI-specific.

Also, figure out a way to integrate with:
https://codereview.chromium.org/2013573007/#msg14

I proposed to mmenke@ that we change:

  void logging::SetLogMessageHandler(...handler..);

to

  scoped_ptr<ListenerHandle> logging::AddLogMessageListener(...listener...);

This would be a semantic change for some existing consumers, but they all
seem to only want to listen to the contents and not actually handle them.

This would also allow logging to remain unchanged and remove global
overriding, which may have unexpected side-effects.

BUG=615626
==========

Powered by Google App Engine
This is Rietveld 408576698