Fix FTP directory listing page error by adding "language" key

Fix FTP directory listing page error by adding "language" key

Also shuffle some test code around so bugs like this can be more easily
noticed by bots.

R=mmenke@chromium.org
BUG=615626
Committed: https://crrev.com/d0039e587748cb814324eefb9941a4706ebc5c2c
Cr-Commit-Position: refs/heads/master@{#398212}

[mmenke, 2016-06-03 16:05:51]

https://codereview.chromium.org/2032903004/diff/1/chrome/browser/net/ftp_brow...
File chrome/browser/net/ftp_browsertest.cc (right):

https://codereview.chromium.org/2032903004/diff/1/chrome/browser/net/ftp_brow...
chrome/browser/net/ftp_browsertest.cc:30: FAIL();
ADD_FAILURE()?  The FAIL macro includes a return statement, just like the ASSERT
ones do.

https://codereview.chromium.org/2032903004/diff/1/chrome/test/base/javascript...
File chrome/test/base/javascript_browser_test.cc (right):

https://codereview.chromium.org/2032903004/diff/1/chrome/test/base/javascript...
chrome/test/base/javascript_browser_test.cc:17: bool g_has_console_info = false;
Can we not use globals here, and get rid of set_has_console_errors?  Note that
when the test fixture is torn down, we also tear down the UI thread, so you can
actually make this a member of JavaScriptBrowserTest, and use base::Unretained
in your bind call.  Or you could use a weak pointer, if you prefer.

If this is called on some thread other than the UI thread, then we should post a
task over to the UI thread to inform it of the error.

[Dan Beam, 2016-06-03 18:58:27]

https://codereview.chromium.org/2032903004/diff/1/chrome/browser/net/ftp_brow...
File chrome/browser/net/ftp_browsertest.cc (right):

https://codereview.chromium.org/2032903004/diff/1/chrome/browser/net/ftp_brow...
chrome/browser/net/ftp_browsertest.cc:30: FAIL();
On 2016/06/03 16:05:51, mmenke wrote:
> ADD_FAILURE()?  The FAIL macro includes a return statement, just like the
ASSERT
> ones do.

Done.

https://codereview.chromium.org/2032903004/diff/1/chrome/test/base/javascript...
File chrome/test/base/javascript_browser_test.cc (right):

https://codereview.chromium.org/2032903004/diff/1/chrome/test/base/javascript...
chrome/test/base/javascript_browser_test.cc:17: bool g_has_console_info = false;
On 2016/06/03 16:05:51, mmenke wrote:
> Can we not use globals here, and get rid of set_has_console_errors?  Note that
> when the test fixture is torn down, we also tear down the UI thread, so you
can
> actually make this a member of JavaScriptBrowserTest, and use base::Unretained
> in your bind call.  Or you could use a weak pointer, if you prefer.
> 
> If this is called on some thread other than the UI thread, then we should post
a
> task over to the UI thread to inform it of the error.

i can move the booleans wherever you'd like, PostTasks, run message loops, but
logging::SetLogMessageHandler() is currently always global

[Dan Beam, 2016-06-07 01:19:11]

ping

[mmenke, 2016-06-07 01:41:51]

LGTM

[Dan Beam, 2016-06-07 01:48:31]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-06-07 01:48:47]

"tests" split out here: https://codereview.chromium.org/2045843002

[commit-bot: I haz the power, 2016-06-07 01:48:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2032903004/40001

[commit-bot: I haz the power, 2016-06-07 02:58:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-07 03:01:22]

Description was changed from

==========
Fix FTP directory listing page error by adding "language" key

Also shuffle some test code around so bugs like this can be more easily
noticed by bots.

R=mmenke@chromium.org
BUG=615626
==========

to

==========
Fix FTP directory listing page error by adding "language" key

Also shuffle some test code around so bugs like this can be more easily
noticed by bots.

R=mmenke@chromium.org
BUG=615626

Committed: https://crrev.com/d0039e587748cb814324eefb9941a4706ebc5c2c
Cr-Commit-Position: refs/heads/master@{#398212}
==========

[commit-bot: I haz the power, 2016-06-07 03:01:22]

Patchset 3 (id:??) landed as
https://crrev.com/d0039e587748cb814324eefb9941a4706ebc5c2c
Cr-Commit-Position: refs/heads/master@{#398212}