Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6347)

Unified Diff: chrome/test/base/javascript_browser_test.h

Issue 2045843002: Move console error detection in browser tests to higher level (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ftp-error
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/ftp_browsertest.cc ('k') | chrome/test/base/javascript_browser_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/javascript_browser_test.h
diff --git a/chrome/test/base/javascript_browser_test.h b/chrome/test/base/javascript_browser_test.h
index 2299cff9db1a881e6f68b52df74f58daad3a8239..747655a42f0dd22eddbe0f611e340c7896c54f78 100644
--- a/chrome/test/base/javascript_browser_test.h
+++ b/chrome/test/base/javascript_browser_test.h
@@ -34,6 +34,7 @@ class JavaScriptBrowserTest : public InProcessBrowserTest {
// InProcessBrowserTest overrides.
void SetUpOnMainThread() override;
+ void TearDownOnMainThread() override;
// Builds a vector of strings of all added javascript libraries suitable for
// execution by subclasses.
@@ -47,6 +48,12 @@ class JavaScriptBrowserTest : public InProcessBrowserTest {
const std::string& test_name,
const ConstValueVector& args);
+ bool has_console_errors() const;
+ void set_has_console_errors(bool has_console_errors);
+
+ bool has_console_info() const;
+ void set_has_console_info(bool has_console_errors);
+
private:
// User added libraries.
std::vector<base::FilePath> user_libraries_;
« no previous file with comments | « chrome/browser/net/ftp_browsertest.cc ('k') | chrome/test/base/javascript_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698