Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2045003002: Make the data pipe "cancel all state" functions cancel two-phase operations. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make the data pipe "cancel all state" functions cancel two-phase operations. Refactor some code paths to share more code. This leads to (very slight) redundancy in a couple of code paths, because on closing a handle both "cancel all state" and "close" get called. See the commit message for c59a3473231b17af071fc401fdd66ec0adbcdd4c for details about why this is being done. This CL doesn't actually change any visible behavior. R=azani@chromium.org BUG=#782 Committed: https://chromium.googlesource.com/external/mojo/+/f54da366a84db70d2aa6a747b91f3e30b8e8df00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -27 lines) Patch
M mojo/edk/system/data_pipe.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 7 chunks +26 lines, -27 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
viettrungluu
4 years, 6 months ago (2016-06-07 20:22:42 UTC) #1
azani
lgtm
4 years, 6 months ago (2016-06-07 23:22:10 UTC) #3
viettrungluu
4 years, 6 months ago (2016-06-08 00:15:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f54da366a84db70d2aa6a747b91f3e30b8e8df00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698