Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2042363003: Allow data pipe producer/consumer handles to be transferred during two-phase operations. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work790_dp_cancel_two_phase
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Allow data pipe producer/consumer handles to be transferred during two-phase operations. Instead of failing with "busy", abort the two-phase operation. To do (separately): Remove the various IsBusy() (etc.) methods -- the only uses were for the data pipe producer/consumer handles. R=azani@chromium.org BUG=#782 Committed: https://chromium.googlesource.com/external/mojo/+/9979f25c746c7f6a957d786786a0fc21a336079a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -22 lines) Patch
M mojo/edk/system/core_unittest.cc View 2 chunks +64 lines, -7 lines 0 comments Download
M mojo/edk/system/handle_table.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M mojo/public/c/system/data_pipe.h View 2 chunks +18 lines, -0 lines 0 comments Download
M mojo/public/c/system/handle.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/message_pipe.h View 1 chunk +5 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-07 21:19:57 UTC) #1
viettrungluu
On 2016/06/07 21:19:57, viettrungluu wrote: (Depends on https://codereview.chromium.org/2045003002/, obviously.)
4 years, 6 months ago (2016-06-07 21:20:33 UTC) #2
azani
lgtm
4 years, 6 months ago (2016-06-07 23:22:44 UTC) #3
viettrungluu
4 years, 6 months ago (2016-06-08 00:16:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9979f25c746c7f6a957d786786a0fc21a336079a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698