Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2044853002: [perf] Prepare benchmarks for memory metric normalization (Closed)

Created:
4 years, 6 months ago by petrcermak
Modified:
4 years, 6 months ago
Reviewers:
nednguyen, ulan, mythria
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[perf] Prepare benchmarks for memory metric normalization This is patch is necessary so that benchmarks using the memory metric wouldn't stop reporting values once https://codereview.chromium.org/2018503002/ lands. BUG=617117 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/b5ab3f3839905899869fa80764428c50642fb560 Cr-Commit-Position: refs/heads/master@{#398620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M tools/perf/benchmarks/memory_infra.py View 2 chunks +11 lines, -1 line 0 comments Download
M tools/perf/benchmarks/v8.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 6 months ago (2016-06-07 12:58:46 UTC) #3
nednguyen
lgtm
4 years, 6 months ago (2016-06-07 14:46:53 UTC) #4
mythria
Thanks, lgtm.
4 years, 6 months ago (2016-06-07 14:49:09 UTC) #5
ulan
lgtm
4 years, 6 months ago (2016-06-07 14:49:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044853002/1
4 years, 6 months ago (2016-06-08 13:53:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_cq/builds/251)
4 years, 6 months ago (2016-06-08 17:40:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044853002/1
4 years, 6 months ago (2016-06-08 18:14:06 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 18:19:36 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 18:21:31 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5ab3f3839905899869fa80764428c50642fb560
Cr-Commit-Position: refs/heads/master@{#398620}

Powered by Google App Engine
This is Rietveld 408576698