Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/perf/benchmarks/memory_infra.py

Issue 2044853002: [perf] Prepare benchmarks for memory metric normalization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/memory_infra.py
diff --git a/tools/perf/benchmarks/memory_infra.py b/tools/perf/benchmarks/memory_infra.py
index 1ac4e7d78ce1b4f26b7ff309bfa4fc5158a2179c..7e9e28b177cbf01613505b372af76cf21607adad 100644
--- a/tools/perf/benchmarks/memory_infra.py
+++ b/tools/perf/benchmarks/memory_infra.py
@@ -162,6 +162,12 @@ class RendererMemoryBlinkMemoryMobile(_MemoryInfra):
class _MemoryV8Benchmark(_MemoryInfra):
+
+ # Report only V8-specific and overall renderer memory values. Note that
+ # detailed values reported by the OS (such as native heap) are excluded.
+ _V8_AND_OVERALL_MEMORY_RE = re.compile(
+ r'renderer:(reported_by_chrome:v8|reported_by_os:system:[^:]+$)')
+
def CreateTimelineBasedMeasurementOptions(self):
v8_categories = [
'blink.console', 'renderer.scheduler', 'v8', 'webkit.console']
@@ -175,8 +181,12 @@ class _MemoryV8Benchmark(_MemoryInfra):
@classmethod
def ValueCanBeAddedPredicate(cls, value, _):
if 'memory:chrome' in value.name:
+ # TODO(petrcermak): Remove the first two cases once
+ # https://codereview.chromium.org/2018503002/ lands in Catapult and rolls
+ # into Chromium.
return ('renderer:subsystem:v8' in value.name or
- 'renderer:vmstats:overall' in value.name)
+ 'renderer:vmstats:overall' in value.name or
+ bool(cls._V8_AND_OVERALL_MEMORY_RE.search(value.name)))
return 'v8' in value.name
« no previous file with comments | « no previous file | tools/perf/benchmarks/v8.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698