| OLD | NEW |
| 1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 import os | 4 import os |
| 5 import re | 5 import re |
| 6 | 6 |
| 7 from core import path_util | 7 from core import path_util |
| 8 from core import perf_benchmark | 8 from core import perf_benchmark |
| 9 from page_sets import google_pages | 9 from page_sets import google_pages |
| 10 | 10 |
| (...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 220 @classmethod | 220 @classmethod |
| 221 def ShouldTearDownStateAfterEachStoryRun(cls): | 221 def ShouldTearDownStateAfterEachStoryRun(cls): |
| 222 return True | 222 return True |
| 223 | 223 |
| 224 @classmethod | 224 @classmethod |
| 225 def ValueCanBeAddedPredicate(cls, value, is_first_result): | 225 def ValueCanBeAddedPredicate(cls, value, is_first_result): |
| 226 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard | 226 # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard |
| 227 # is able to cope with the data load generated by TBMv2 metrics. | 227 # is able to cope with the data load generated by TBMv2 metrics. |
| 228 if 'memory' not in value.name: | 228 if 'memory' not in value.name: |
| 229 return True # Keep all non-memory values. | 229 return True # Keep all non-memory values. |
| 230 if 'subsystem' in value.name and 'v8' not in value.name: | 230 # TODO(petrcermak): Remove the 'subsystem' disjunct once |
| 231 # https://codereview.chromium.org/2018503002/ lands in Catapult and rolls |
| 232 # into Chromium. |
| 233 if (('subsystem' in value.name or 'reported_by_chrome' in value.name) and |
| 234 'v8' not in value.name): |
| 231 return False # Drop non-V8 values reported by Chrome. | 235 return False # Drop non-V8 values reported by Chrome. |
| 232 # Keep dump counts and average+max of process counts, vmstats and v8. | 236 # Keep dump counts and average+max of process counts, vmstats and v8. |
| 233 return not cls._IGNORED_V8_STATS_RE.search(value.name) | 237 return not cls._IGNORED_V8_STATS_RE.search(value.name) |
| 234 | 238 |
| 235 | 239 |
| 236 @benchmark.Disabled('reference') | 240 @benchmark.Disabled('reference') |
| 237 # TODO(mythria): Temporarily disable this benchmark for mac. Scrolling | 241 # TODO(mythria): Temporarily disable this benchmark for mac. Scrolling |
| 238 # does not work on for google.com web page. Remove this once it is fixed. | 242 # does not work on for google.com web page. Remove this once it is fixed. |
| 239 @benchmark.Disabled('mac') | 243 @benchmark.Disabled('mac') |
| 240 class V8MobileCodeSizeIgnition(_V8MemoryAndCodeSizeBenchmark): | 244 class V8MobileCodeSizeIgnition(_V8MemoryAndCodeSizeBenchmark): |
| (...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 291 def Name(cls): | 295 def Name(cls): |
| 292 return 'v8.google' | 296 return 'v8.google' |
| 293 | 297 |
| 294 @classmethod | 298 @classmethod |
| 295 def ShouldDisable(cls, possible_browser): | 299 def ShouldDisable(cls, possible_browser): |
| 296 return cls.IsSvelte(possible_browser) # http://crbug.com/596556 | 300 return cls.IsSvelte(possible_browser) # http://crbug.com/596556 |
| 297 | 301 |
| 298 @classmethod | 302 @classmethod |
| 299 def ShouldTearDownStateAfterEachStoryRun(cls): | 303 def ShouldTearDownStateAfterEachStoryRun(cls): |
| 300 return True | 304 return True |
| OLD | NEW |