Remember inside an ICData if it is for a static call or an instance call

Remember inside an ICData if it is for a static call or an instance call

- [x] Add an is static call bit to ICData
- [x] Rewrite the reset ICData iterators to rely on that bit rather than the function's ic data map

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/9256d49af59473f9693c8a60bfe30995c0fb5cec

[Cutch, 2016-06-08 21:27:08]

Description was changed from

==========
Remember inside an ICData if it is for a static call or an instance call

- [x] Add an is static call bit to ICData
- [x] Rewrite the reset ICData iterators to rely on that bit rather than the
function's ic data map

BUG=
==========

to

==========
Remember inside an ICData if it is for a static call or an instance call

- [x] Add an is static call bit to ICData
- [x] Rewrite the reset ICData iterators to rely on that bit rather than the
function's ic data map

BUG=
==========

[Cutch, 2016-06-08 21:27:08]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-06-08 22:10:36]

https://codereview.chromium.org/2044423003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2044423003/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:13451: intptr_t num_args_tested) {
There are more places in flow_graph_inliner, jit_optimizer and aot_optimzier
that don't set is_static_call. Maybe add is_static_call parameter here instead.

https://codereview.chromium.org/2044423003/diff/1/runtime/vm/object_reload.cc
File runtime/vm/object_reload.cc (right):

https://codereview.chromium.org/2044423003/diff/1/runtime/vm/object_reload.cc...
runtime/vm/object_reload.cc:59: void Code::ResetICDatas(const Function&
function) const {
Unused parameter.

[Cutch, 2016-06-08 23:33:53]

https://codereview.chromium.org/2044423003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2044423003/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:13451: intptr_t num_args_tested) {
On 2016/06/08 22:10:36, rmacnak wrote:
> There are more places in flow_graph_inliner, jit_optimizer and aot_optimzier
> that don't set is_static_call. Maybe add is_static_call parameter here
instead.

Done.

https://codereview.chromium.org/2044423003/diff/1/runtime/vm/object_reload.cc
File runtime/vm/object_reload.cc (right):

https://codereview.chromium.org/2044423003/diff/1/runtime/vm/object_reload.cc...
runtime/vm/object_reload.cc:59: void Code::ResetICDatas(const Function&
function) const {
On 2016/06/08 22:10:36, rmacnak wrote:
> Unused parameter.

Done.

[rmacnak, 2016-06-08 23:41:14]

lgtm

[Cutch, 2016-06-13 20:09:52]

Description was changed from

==========
Remember inside an ICData if it is for a static call or an instance call

- [x] Add an is static call bit to ICData
- [x] Rewrite the reset ICData iterators to rely on that bit rather than the
function's ic data map

BUG=
==========

to

==========
Remember inside an ICData if it is for a static call or an instance call

- [x] Add an is static call bit to ICData
- [x] Rewrite the reset ICData iterators to rely on that bit rather than the
function's ic data map

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9256d49af59473f9693c8a60bfe30995c0fb5cec
==========

[Cutch, 2016-06-13 20:09:54]

Committed patchset #2 (id:20001) manually as
9256d49af59473f9693c8a60bfe30995c0fb5cec (presubmit successful).

[Cutch, 2016-06-13 20:22:42]

On 2016/06/13 20:09:54, Cutch wrote:
> Committed patchset #2 (id:20001) manually as
> 9256d49af59473f9693c8a60bfe30995c0fb5cec (presubmit successful).

The right version of this CL was committed from this CL:
https://codereview.chromium.org/2064693003