Issue 2064693003: Remember inside an ICData if it is for a static call or an instance call

Issue 2064693003: Remember inside an ICData if it is for a static call or an instance call (Closed)

Created:
4 years, 6 months ago by Cutch

Modified:
4 years, 6 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remember inside an ICData if it is for a static call or an instance call - [x] Add an is static call bit to ICData - [x] Rewrite the reset ICData iterators to rely on that bit rather than the function's ic data map BUG= Committed: https://github.com/dart-lang/sdk/commit/c0eb4d9dc00ace981e3fdcfbe1e00b698b07b951

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -111 lines)			Patch
M	runtime/vm/aot_optimizer.cc	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/code_patcher_arm64_test.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/code_patcher_arm_test.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/code_patcher_ia32_test.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/code_patcher_mips_test.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/code_patcher_x64_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	6 chunks	+12 lines, -6 lines	0 comments	Download
M	runtime/vm/intrinsifier.cc	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/isolate_reload.cc	View	4 chunks	+5 lines, -46 lines	0 comments	Download
M	runtime/vm/jit_optimizer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	8 chunks	+19 lines, -5 lines	0 comments	Download
M	runtime/vm/object.cc	View	7 chunks	+22 lines, -5 lines	0 comments	Download
M	runtime/vm/object_reload.cc	View	2 chunks	+39 lines, -31 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 6 (3 generated)

Cutch

TBRing because I accidentally landed an older version of this CL in the original issue ...

4 years, 6 months ago (2016-06-13 20:23:28 UTC) #3

Cutch

Committed patchset #1 (id:1) manually as c0eb4d9dc00ace981e3fdcfbe1e00b698b07b951 (presubmit successful).

4 years, 6 months ago (2016-06-13 20:24:04 UTC) #5

Message was sent while issue was closed.

lgtm