Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Side by Side Diff: runtime/vm/code_patcher_x64_test.cc

Issue 2044423003: Remember inside an ICData if it is for a static call or an instance call (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/code_patcher_mips_test.cc ('k') | runtime/vm/flow_graph_compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 22 matching lines...) Expand all
33 true, false, false, false, false, owner_class, 33 true, false, false, false, false, owner_class,
34 TokenPosition::kNoSource)); 34 TokenPosition::kNoSource));
35 35
36 const String& target_name = String::Handle(String::New("targetFunction")); 36 const String& target_name = String::Handle(String::New("targetFunction"));
37 const Array& args_descriptor = 37 const Array& args_descriptor =
38 Array::Handle(ArgumentsDescriptor::New(1, Object::null_array())); 38 Array::Handle(ArgumentsDescriptor::New(1, Object::null_array()));
39 const ICData& ic_data = ICData::ZoneHandle(ICData::New(function, 39 const ICData& ic_data = ICData::ZoneHandle(ICData::New(function,
40 target_name, 40 target_name,
41 args_descriptor, 41 args_descriptor,
42 15, 42 15,
43 1)); 43 1, false));
44 44
45 // Code accessing pp is generated, but not executed. Uninitialized pp is OK. 45 // Code accessing pp is generated, but not executed. Uninitialized pp is OK.
46 __ set_constant_pool_allowed(true); 46 __ set_constant_pool_allowed(true);
47 47
48 __ LoadObject(RBX, ic_data); 48 __ LoadObject(RBX, ic_data);
49 __ CallPatchable(*StubCode::OneArgCheckInlineCache_entry()); 49 __ CallPatchable(*StubCode::OneArgCheckInlineCache_entry());
50 __ ret(); 50 __ ret();
51 } 51 }
52 52
53 53
54 ASSEMBLER_TEST_RUN(IcDataAccess, test) { 54 ASSEMBLER_TEST_RUN(IcDataAccess, test) {
55 uword return_address = test->entry() + CodePatcher::InstanceCallSizeInBytes(); 55 uword return_address = test->entry() + CodePatcher::InstanceCallSizeInBytes();
56 ICData& ic_data = ICData::Handle(); 56 ICData& ic_data = ICData::Handle();
57 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data); 57 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data);
58 EXPECT_STREQ("targetFunction", 58 EXPECT_STREQ("targetFunction",
59 String::Handle(ic_data.target_name()).ToCString()); 59 String::Handle(ic_data.target_name()).ToCString());
60 EXPECT_EQ(1, ic_data.NumArgsTested()); 60 EXPECT_EQ(1, ic_data.NumArgsTested());
61 EXPECT_EQ(0, ic_data.NumberOfChecks()); 61 EXPECT_EQ(0, ic_data.NumberOfChecks());
62 } 62 }
63 63
64 } // namespace dart 64 } // namespace dart
65 65
66 #endif // TARGET_ARCH_X64 66 #endif // TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/code_patcher_mips_test.cc ('k') | runtime/vm/flow_graph_compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698