Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2044153002: Move ReferenceFilterBuilder::build to FilterEffectBuilder (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@filter-remove-reffilter-vector-feb
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ReferenceFilterBuilder::build to FilterEffectBuilder This function resolves a filter reference and then builds a filter (sub)DAG for painting. Split it into the two fairly distinct parts, leaving ReferenceFilterBuilder as a class that only does element lookup/resolution, while the DAG-building takes place in FilterEffectBuilder (with a little help from SVGFilterBuilder.) Use the new function in SVGFilterPainter. Also pass Element& to ReferenceFilterBuilder::build, and remove a redundant null-check of ComputedStyle in PaintLayer::updateOrRemoveFilterEffectBuilder (already checked by paintsWithFilters and assumed later in the function.) BUG=109224, 533457 Committed: https://crrev.com/20a5c045d0eb975be198b14204ce5eb6a5ab60e2 Cr-Commit-Position: refs/heads/master@{#398866}

Patch Set 1 #

Patch Set 2 : Workaround empty filterRegion discrepancy. #

Total comments: 7

Patch Set 3 : zoomedReferenceBoxSize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -79 lines) Patch
M third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.h View 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp View 3 chunks +6 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterEffectBuilder.h View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp View 1 2 5 chunks +62 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 2 chunks +11 lines, -29 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
fs
https://codereview.chromium.org/2044153002/diff/20001/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp File third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp (right): https://codereview.chromium.org/2044153002/diff/20001/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp#newcode309 third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp:309: if (nodeMap && filterRegion.isEmpty()) This is a bit ugly, ...
4 years, 6 months ago (2016-06-08 10:51:36 UTC) #2
Stephen White
LGTM I don't *think* it will be affected, but one case to keep an eye ...
4 years, 6 months ago (2016-06-08 13:53:45 UTC) #3
fs
On 2016/06/08 at 13:53:45, senorblanco wrote: > LGTM > > I don't *think* it will ...
4 years, 6 months ago (2016-06-08 14:08:42 UTC) #4
pdr.
LGTM with or without my suggestion. https://codereview.chromium.org/2044153002/diff/20001/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h File third_party/WebKit/Source/core/paint/FilterEffectBuilder.h (right): https://codereview.chromium.org/2044153002/diff/20001/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h#newcode54 third_party/WebKit/Source/core/paint/FilterEffectBuilder.h:54: static Filter* buildReferenceFilter(SVGFilterElement&, ...
4 years, 6 months ago (2016-06-08 23:12:51 UTC) #5
fs
https://codereview.chromium.org/2044153002/diff/20001/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h File third_party/WebKit/Source/core/paint/FilterEffectBuilder.h (right): https://codereview.chromium.org/2044153002/diff/20001/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h#newcode54 third_party/WebKit/Source/core/paint/FilterEffectBuilder.h:54: static Filter* buildReferenceFilter(SVGFilterElement&, const FloatRect& referenceBox, const SkPaint* fillPaint, ...
4 years, 6 months ago (2016-06-09 08:33:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044153002/40001
4 years, 6 months ago (2016-06-09 13:28:04 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 13:59:49 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 14:01:10 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20a5c045d0eb975be198b14204ce5eb6a5ab60e2
Cr-Commit-Position: refs/heads/master@{#398866}

Powered by Google App Engine
This is Rietveld 408576698